Re: Review Request: Implement saving for the KoUnavailShape

2011-04-14 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review2627 --- Ok, fixed it all except for the issue in the vector shape and on

Re: Review Request: Implement saving for the KoUnavailShape

2011-04-01 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/ --- (Updated April 1, 2011, 3:44 p.m.) Review request for Calligra. Changes

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-13 Thread Inge Wallin
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > libs/odf/KoEmbeddedFileSaver.h, line 56 > > > > > > Please pass contents as a const & > > Inge Wallin wrote: > No, I don't think we should do that, and t

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-13 Thread Thorsten Zachmann
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > libs/odf/KoEmbeddedFileSaver.h, line 56 > > > > > > Please pass contents as a const & > > Inge Wallin wrote: > No, I don't think we should do that, and t

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Inge Wallin
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > libs/odf/KoEmbeddedFileSaver.cpp, line 82 > > > > > > any reason to make the number at least 4 chars long? It just felt right. > On Feb. 13, 2011, 5:09 a.m

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1398 --- I have created a presentation containing an embedded text docume

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > Please implement the comments and post for review again. I have not yet done a functional testing bug that will follow. - Thorsten --- This is an automatically generated e-mail

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1396 --- Please implement the comments and post for review again. brain

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1377 --- Can you please wait before committing I would like to review and

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1374 --- Ship it! I'm not totally happy with having to add code to so ma