Organisation of port work (Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-21 Thread Friedrich W. H. Kossebau
Two weeks ago or so Inge put it nicely on #calligra IMHO: There are 3 phases of the port: 1. Initial port of buildsystem (done now, thanks Boud) 2. Readding everything to build (minimal port, using kdelibs4support) 3. Porting away from kdelibs4support and other deprecated stuff So seems in the

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Ben Cooksley
On Thu, Mar 5, 2015 at 12:56 AM, Jaroslaw Staniek wrote: > Nice thanks. > I see 28% of changes are non-whitespace. > Forcing {} for if/else is good. > > Could we please exclude dirs that contain forked code that would be > compared to external copies? > One comes to my mind: kexi/migration/mdb/src

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Boudewijn Rempt
Please directories that should be excluded to a list at https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit?usp=sharing On Wed, 4 Mar 2015, Jaroslaw Staniek wrote: Nice thanks. I see 28% of changes are non-whitespace. Forcing {} for if/else is good. Could we p

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Jaroslaw Staniek
Nice thanks. I see 28% of changes are non-whitespace. Forcing {} for if/else is good. Could we please exclude dirs that contain forked code that would be compared to external copies? One comes to my mind: kexi/migration/mdb/src/mdbtools/. Anything else? For the future I'd use the tool as a local

Re: RFC: plan for starting the Qt5/KF5 port

2015-03-04 Thread Boudewijn Rempt
On Tue, 3 Mar 2015, Friedrich W. H. Kossebau wrote: Other than that it seems to me no one now strongly rejects * astyle-kdelibs being applied to all of Calligra code * doing that in master * right before the port starts. Does this sounds like something that will make most people happy and least

Re: RFC: plan for starting the Qt5/KF5 port

2015-03-03 Thread Jaroslaw Staniek
On 3 March 2015 at 23:18, Friedrich W. H. Kossebau wrote: > Am Freitag, 27. Februar 2015, 22:49:54 schrieb Jaroslaw Staniek: >> On 27 February 2015 at 01:36, Friedrich W. H. Kossebau > wrote: >> > Am Mittwoch, 25. Februar 2015, 09:39:27 schrieb Jaroslaw Staniek: >> >> On 25 February 2015 at 01:01

Re: RFC: plan for starting the Qt5/KF5 port

2015-03-03 Thread Friedrich W. H. Kossebau
Am Freitag, 27. Februar 2015, 19:03:30 schrieb Thorsten Zachmann: > Hello, > > > I say it should be done now, and be done to 2.9 too > > > > And I almost don't think maintainers should be able to say no. The long > > term goal of having a clean codebase is more important than short term > > issue

Re: RFC: plan for starting the Qt5/KF5 port

2015-03-03 Thread Friedrich W. H. Kossebau
Am Freitag, 27. Februar 2015, 22:49:54 schrieb Jaroslaw Staniek: > On 27 February 2015 at 01:36, Friedrich W. H. Kossebau wrote: > > Am Mittwoch, 25. Februar 2015, 09:39:27 schrieb Jaroslaw Staniek: > >> On 25 February 2015 at 01:01, Friedrich W. H. Kossebau > > > > wrote: > >> > Am Dienstag, 2

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread Jaroslaw Staniek
On 27 February 2015 at 01:36, Friedrich W. H. Kossebau wrote: > Am Mittwoch, 25. Februar 2015, 09:39:27 schrieb Jaroslaw Staniek: >> On 25 February 2015 at 01:01, Friedrich W. H. Kossebau > wrote: >> > Am Dienstag, 24. Februar 2015, 12:18:29 schrieb Jaroslaw Staniek: >> >> On 24 February 2015 at

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread Jaroslaw Staniek
On 27 February 2015 at 19:03, Thorsten Zachmann wrote: > Hello, > >> >> I say it should be done now, and be done to 2.9 too >> >> And I almost don't think maintainers should be able to say no. The long term >> goal of having a clean codebase is more important than short term issue >> with git blam

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread Thorsten Zachmann
Hello, > > I say it should be done now, and be done to 2.9 too > > And I almost don't think maintainers should be able to say no. The long term > goal of having a clean codebase is more important than short term issue > with git blame (have a separate permanent checkout before this revision > wh

Re: Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread C. Boemann
On Friday 27 February 2015 01:21:56 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 25. Februar 2015, 15:41:33 schrieb Boudewijn Rempt: > > On Wed, 25 Feb 2015, Dmitry Kazakov wrote: > > > Hi! > > > > > > My 2 cents :) > > > > > > 1) astyle > > > > > > Last time astyle was applied to Krita code (

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Cyrille Berger
On 2015-02-27 01:21, Friedrich W. H. Kossebau wrote: If not using astyle on calligra/2.9, then it should be better only applied at the end of the porting, close to 3.0 release, to not complicate forward porting of commits to calligra/2.9. Would you agree? Perhaps also even only after 3.0, during

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Friedrich W. H. Kossebau
Am Mittwoch, 25. Februar 2015, 09:39:27 schrieb Jaroslaw Staniek: > On 25 February 2015 at 01:01, Friedrich W. H. Kossebau wrote: > > Am Dienstag, 24. Februar 2015, 12:18:29 schrieb Jaroslaw Staniek: > >> On 24 February 2015 at 11:24, Mario Fux wrote: > >> > Am Dienstag, 24. Februar 2015, 08.51:

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Friedrich W. H. Kossebau
Am Mittwoch, 25. Februar 2015, 08:33:25 schrieb Jaroslaw Staniek: > On 25 February 2015 at 01:01, Friedrich W. H. Kossebau wrote: > > Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: > >> As a sidenote, I also want to take the opportunity to do a clean-up step, > >> but I'm not su

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Friedrich W. H. Kossebau
Am Mittwoch, 25. Februar 2015, 15:41:33 schrieb Boudewijn Rempt: > On Wed, 25 Feb 2015, Dmitry Kazakov wrote: > > Hi! > > > > My 2 cents :) > > > > 1) astyle > > > > Last time astyle was applied to Krita code (something around 2010-2011, it > > was applied partially?) I really didn't like the re

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Friedrich W. H. Kossebau
Am Mittwoch, 25. Februar 2015, 09:21:14 schrieb Boudewijn Rempt: > On Wed, 25 Feb 2015, Friedrich W. H. Kossebau wrote: > > Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: > >> * rename all krita files to the calligra standard. (cc -> cpp, underscore > >> -> CamelCaps) > >> > >> *

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-26 Thread Jaroslaw Staniek
Thanks, Added https://community.kde.org/Calligra/Schedules/3.0/Porting_Plan#Patches_to_merge Please update. @Roman - your 2 patches are there @Wojtek - I'll review your patch very soon, let's get it pushed on time On 25 February 2015 at 01:03, Friedrich W. H. Kossebau wrote: > Started to docum

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread Jaroslaw Staniek
On 25 February 2015 at 01:01, Friedrich W. H. Kossebau wrote: > Am Dienstag, 24. Februar 2015, 12:18:29 schrieb Jaroslaw Staniek: >> On 24 February 2015 at 11:24, Mario Fux wrote: >> > Am Dienstag, 24. Februar 2015, 08.51:56 schrieb Jaroslaw Staniek: >> >> On 24 February 2015 at 03:55, Friedrich

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread Boudewijn Rempt
On Wed, 25 Feb 2015, Friedrich W. H. Kossebau wrote: Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: As a sidenote, I also want to take the opportunity to do a clean-up step, but I'm not sure what the right moment or place is. It might even something to do in the 2.9 branch aft

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread Cyrille Berger
On Wednesday 25 February 2015 01:01:57 Friedrich W. H. Kossebau wrote: > Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: > > As a sidenote, I also want to take the opportunity to do a clean-up step, > > but I'm not sure what the right moment or place is. It might even > > something

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Started to document all the things written on https://community.kde.org/Calligra/Schedules/3.0/Porting_Plan Please review, update & comment also there :) Cheers Friedrich ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.or

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: > As a sidenote, I also want to take the opportunity to do a clean-up step, > but I'm not sure what the right moment or place is. It might even > something to do in the 2.9 branch after tagging... > > * replace all header guards with

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 08:51:56 schrieb Jaroslaw Staniek: > On 24 February 2015 at 03:55, Friedrich W. H. Kossebau wrote: > > 4. Remove these subdirs: > >3rdparty/kdchart/ > >3rdparty/kdchartpatches/ > >3rdparty/kdgantt/ > >3rdparty/kdganttpatches/ > >libs/koproperty/

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 12:18:29 schrieb Jaroslaw Staniek: > On 24 February 2015 at 11:24, Mario Fux wrote: > > Am Dienstag, 24. Februar 2015, 08.51:56 schrieb Jaroslaw Staniek: > >> On 24 February 2015 at 03:55, Friedrich W. H. Kossebau > >> > To not have people step on each other toes an

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Mario Fux
Am Dienstag, 24. Februar 2015, 08.51:56 schrieb Jaroslaw Staniek: > On 24 February 2015 at 03:55, Friedrich W. H. Kossebau wrote: Morning [snip] > > Reasoning: > > -- > > Calligra has over 4 M lines (claims openhub.net, not counted myself), so > > expecting one person to do all the ini

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
On Tue, 24 Feb 2015, Tomas Mecir wrote: 2015-02-24 3:55 GMT+01:00 Friedrich W. H. Kossebau : PS: Tomas, you had done some initial buildsystem porting experients, right? Would you be willing to be the person to do the initial porting steps? Hmm, do we have more Tomases? Because I d

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
On Tue, 24 Feb 2015, Jaroslaw Staniek wrote: On 24 February 2015 at 09:47, Boudewijn Rempt wrote: Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my copies of the original mail, or they never arrived :-( As a sidenote, I also want to take the opportunity to do a clean-up s

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Jaroslaw Staniek
On 24 February 2015 at 09:47, Boudewijn Rempt wrote: > Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my > copies of the original mail, or they never arrived :-( > > As a sidenote, I also want to take the opportunity to do a clean-up step, > but I'm not sure what the right mo

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my copies of the original mail, or they never arrived :-( As a sidenote, I also want to take the opportunity to do a clean-up step, but I'm not sure what the right moment or place is. It might even something to do in the 2.9