Re: Committing kundo2 patches tomorrow

2011-06-26 Thread Jaroslaw Staniek
On 25 June 2011 23:02, Alexander Potashev wrote: > 2011/6/25 Jaroslaw Staniek : >> Hi, >> Kudos for this contribution but is KUndo2 tested at all, especially with >> Kexi? >> Isn't there a clear infinite recursion at kundo2stack.cpp:1065 and 1084? > > That's clearly my mistake, sorry. Fixed in ma

Re: Committing kundo2 patches tomorrow

2011-06-25 Thread Alexander Potashev
2011/6/25 Jaroslaw Staniek : > Hi, > Kudos for this contribution but is KUndo2 tested at all, especially with Kexi? > Isn't there a clear infinite recursion at kundo2stack.cpp:1065 and 1084? That's clearly my mistake, sorry. Fixed in master, but in a different way than you suggested. I probably d

Re: Committing kundo2 patches tomorrow

2011-06-25 Thread Jaroslaw Staniek
On 20 June 2011 14:22, Alexander Potashev wrote: > Hi, > > I'm going to commit the following 3 patches tomorrow, they will add > kundo2 library and make the whole Calligra use it: > 1. https://git.reviewboard.kde.org/r/101414/ (add kundo2 library) > 2. https://git.reviewboard.kde.org/r/101415/ (li

Re: Committing kundo2 patches tomorrow

2011-06-25 Thread Jaroslaw Staniek
Hi, Kudos for this contribution but is KUndo2 tested at all, especially with Kexi? Isn't there a clear infinite recursion at kundo2stack.cpp:1065 and 1084? -- regards / pozdrawiam, Jaroslaw Staniek  http://www.linkedin.com/in/jstaniek  Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-s

Re: Committing kundo2 patches tomorrow

2011-06-21 Thread Alexander Potashev
Pushed. 2011/6/20 Alexander Potashev : > Hi, > > I'm going to commit the following 3 patches tomorrow, they will add > kundo2 library and make the whole Calligra use it: > 1. https://git.reviewboard.kde.org/r/101414/ (add kundo2 library) > 2. https://git.reviewboard.kde.org/r/101415/ (link Calligr