Re: Questions about shape group

2011-05-03 Thread jaham
On Tuesday 03 May 2011 07:21:50 Yue Liu wrote: > Hello, > > Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to > KoCommand, which now becomes > KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to > move it back to KoShapeGroup, what do you think? >

Re: Questions about shape group

2011-05-02 Thread Yue Liu
Hello, Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to KoCommand, which now becomes KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to move it back to KoShapeGroup, what do you think? https://projects.kde.org/projects/calligra/repository/revisio

Re: Questions about shape group

2011-05-02 Thread jaham
On Thursday 28 April 2011 18:02:34 you wrote: > Also, I noticed that shadow.Insets is considered when calculating the > boundingRect to a shape, is it needed to include the shadow into the > boundingRect? And besides calculating boundingRect, where is shadow.Insets > being used? Yes the shadow ins

Re: Questions about shape group

2011-05-02 Thread jaham
On Thursday 28 April 2011 16:52:17 you wrote: > Hello Jan, > > Should group be redesigned to be a shape (actually I still don't understand > why group inherits shape container and shape container inherits koShape but > group is not a shape) ? Well you already found the correct answer. :-) KoShap