karbon pdf filter

2022-04-04 Thread Jonathan Riddell
ters/libmsooxml/CMakeFiles/komsooxml.dir/MsooXmlThemesReader.cpp.o*08:14:42* /workspace/build/filters/karbon/pdf/PdfImport.cpp: In member function ‘virtual KoFilter::ConversionStatus PdfImport::convert(const QByteArray&, const QByteArray&)’:*08:14:42* /workspace/build/filters/karbon/pdf/PdfImpo

Re: Karbon Color editor missing

2020-03-06 Thread Boudewijn Rempt
As I said, you need to select an object, then select the gradient. Make sure the tool options docker is enabled in Karbon's settings. It might be better to use inkscape, though, since Karbon needs a lot of work done on it still. On donderdag 5 maart 2020 21:28:37 CET JZA wrote: > I fo

Re: Karbon Color editor missing

2020-03-05 Thread JZA
I found some screenshots there was an docker editor but cant pop it up again. https://i2.wp.com/herramientasgratis.com/wp-content/uploads/2018/11/Pantallazo-2.png?resize=768%2C576 On Thu, Mar 5, 2020 at 7:43 AM Boudewijn Rempt wrote: > Editing gradients in Karbon is rather fiddly. You fi

Re: Karbon Color editor missing

2020-03-05 Thread Boudewijn Rempt
Editing gradients in Karbon is rather fiddly. You first have to create an object, select it and then select the on-canvas gradient tool. Then select a gradient, select a stop on canvas, and then in the edit tab of the gradient tool select a new color. I'm not sure myself, since it's a

Karbon Color editor missing

2020-03-04 Thread JZA
I wasnt able to edit a gradient, cant seem to find the color / gradient mixer. Did I miss something? -- Alexandro Colorado GULTab.org Linux User # 319286 Blog: http://www.alexandrocolorado.org/

D25254: Remove flow, not needed since karbon can do it all

2020-03-03 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do it all (authored by danders). REPOSITORY R

Karbon text tool comments, multiline

2020-02-07 Thread JZA
Have some questions, and recommendations. I tried doing text fields but had issues doing multiline on it. Even if I select a height equal to two multiple lines, the text just grows ignoring the default text size on the toolbox. Once is set, is hard to get beyond one line. So inserting a jumpline wi

Re: Karbon improvements

2020-01-07 Thread JZA
On Tue, Jan 7, 2020 at 3:26 AM wrote: > JZA skrev den 2020-01-06 21:37: > > Hi I'm an avid kde user but I still keep some gtk apps like gimp > > (althought using krita more and more), another one is Inkscape and > > here is where maybe Karbon could improve to compete f

Re: Karbon improvements

2020-01-07 Thread danders
JZA skrev den 2020-01-06 21:37: Hi I'm an avid kde user but I still keep some gtk apps like gimp (althought using krita more and more), another one is Inkscape and here is where maybe Karbon could improve to compete for further ease of use. Is a bit ironic that inkscape is one of the fe

Karbon improvements

2020-01-06 Thread JZA
Hi I'm an avid kde user but I still keep some gtk apps like gimp (althought using krita more and more), another one is Inkscape and here is where maybe Karbon could improve to compete for further ease of use. Is a bit ironic that inkscape is one of the few gtk apps that make use of

Removing the unmaintaied tag on karbon

2019-11-19 Thread Harsh Jain
Since Calligra karbon is not unmaintaied now , could you please remove it from the kde unmaintaied page and also possibly release a new version removing the unmaintaied tag and message that pops up on the time of opening it . Thanks

D25254: Remove flow, not needed since karbon can do it all

2019-11-14 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm fine with your decision, just i don't want to be the only person accepted such a change. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, davidllewe

D25254: Remove flow, not needed since karbon can do it all

2019-11-14 Thread Dag Andersen
pp. All functionallity is in the plugins, so flow does not offer any advantage over karbon or words. I'll let this patch rest fttb, a decission can be made closer to next release. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni, #ca

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Camilla Boemann
boemann added a comment. To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow. So I'm okay with it REPOSITORY R8 Calligra REVISION DETAIL https:

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Anthony Fieroni
anthonyfieroni added a reviewer: Calligra: 3.0. anthonyfieroni added a comment. Let's other members leave their opinion as well. I don't want to have surprised people by removing Flow. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni,

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders added a comment. Yeah, well. If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it. As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm unsure about that, if some people still prefer using Flow will make this change superfluous. I can't make decision about this changes, if you think it should be done - i'm fine. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since karbon is multipage app and stencils docker can be used by all apps

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69566&id=69567 REVI

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
5214 AFFECTED FILES filters/karbon/image/ImageExport.cpp filters/karbon/image/ImageExportOptionsWidget.cpp filters/karbon/image/ImageExportOptionsWidget.h filters/karbon/image/ImageExportOptionsWidget.ui To: danders, anthonyfieroni Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, coc

D25214: Karbon image filter: Add multipage support

2019-11-10 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ImageExport.cpp:49 > #include > +#include > Unneeded ? REPOSITORY R8 Calligra BRANCH multipage_image_danders REVISION DETAIL https://phabr

D25214: Karbon image filter: Add multipage support

2019-11-08 Thread Dag Andersen
png and jpeg from page > 1. REPOSITORY R8 Calligra BRANCH multipage_image_danders REVISION DETAIL https://phabricator.kde.org/D25214 AFFECTED FILES filters/karbon/image/ImageExport.cpp filters/karbon/image/ImageExportOptionsWidget.cpp filters/karbon/image/ImageExportOptionsWidge

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69263&id=69300 REVISION DE

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. Just for the record: The pdf filter goes through the svg filter and as s

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
ttps://phabricator.kde.org/D20400 AFFECTED FILES CalligraProducts.cmake filters/karbon/CMakeLists.txt filters/karbon/image/CMakeLists.txt filters/karbon/image/ImageExport.cpp filters/karbon/svg/CMakeLists.txt filters/karbon/svg/SvgExport.cpp filters/karbon/svg/SvgImport.cpp filters/karbon

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
ttps://phabricator.kde.org/D20400 AFFECTED FILES CalligraProducts.cmake filters/karbon/CMakeLists.txt filters/karbon/image/CMakeLists.txt filters/karbon/image/ImageExport.cpp filters/karbon/svg/CMakeLists.txt filters/karbon/svg/SvgExport.cpp filters/karbon/svg/SvgImport.cpp filters/karbon

D20400: Karbon: Enable multi page capability

2019-11-01 Thread Dag Andersen
ttps://phabricator.kde.org/D20400 AFFECTED FILES CalligraProducts.cmake filters/karbon/CMakeLists.txt filters/karbon/image/CMakeLists.txt filters/karbon/image/ImageExport.cpp filters/karbon/svg/CMakeLists.txt filters/karbon/svg/SvgExport.cpp filters/karbon/svg/SvgImport.cpp filters/karbon

D20400: Karbon: Enable multi page capability

2019-06-20 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. I saw filters does not compile when it compile only Karbon, i should correct that, but i have much time now. REPOSITORY R8 Calligra BRANCH karbon_multipage_danders

D20400: Karbon: Enable multi page capability

2019-06-10 Thread Anthony Fieroni
anthonyfieroni added a comment. In D20400#475648 , @danders wrote: > In D20400#475477 , @anthonyfieroni wrote: > > > Now we have insert page, but we don't exports them :) If you think that's ok for

D20400: Karbon: Enable multi page capability

2019-06-07 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. If you mean export to svg here, afaics there are no page element in svg.

D20400: Karbon: Enable multi page capability

2019-06-06 Thread Anthony Fieroni
anthonyfieroni added a comment. Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D20400 To: danders, anthonyfieroni Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vanden

D20400: Karbon: Enable multi page capability

2019-06-06 Thread Dag Andersen
.org/D20400 AFFECTED FILES CalligraProducts.cmake filters/karbon/CMakeLists.txt filters/karbon/image/CMakeLists.txt filters/karbon/image/ImageExport.cpp filters/karbon/svg/CMakeLists.txt filters/karbon/svg/SvgExport.cpp filters/karbon/svg/SvgImport.cpp filters/karbon/wmf/CMakeLists

D20400: Karbon: Enable multi page capability

2019-06-05 Thread Dag Andersen
danders added a comment. I have been pondering why we disagreed so much on the background color, and I *think* I have an answer. My take is it's because we have not been talking about quite the same thing: I have looked at karbon as an *odg* editor, since it uses odg as its native

D20400: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni added a comment. Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right? Full cmake command cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR

D20400: Karbon: Enable multi page capability

2019-06-04 Thread René J . V . Bertin
rjvbb added a comment. > code wise looks good Apparently it tastes good too, better than the 2 previous versions? ;) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D20400 To: danders, anthonyfieroni Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni added a comment. Someone test it, code wise looks good, i plan to test it soon. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D20400 To: danders, anthonyfieroni Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19327: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni abandoned this revision. anthonyfieroni added a comment. In flavor of D20400 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19327 To: anthonyfieroni, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni abandoned this revision. anthonyfieroni added a comment. In flavor of D20400 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: anthonyfieroni, danders Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochis

D19327: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni commandeered this revision. anthonyfieroni edited reviewers, added: danders; removed: anthonyfieroni. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19327 To: anthonyfieroni, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-06-04 Thread Anthony Fieroni
anthonyfieroni commandeered this revision. anthonyfieroni edited reviewers, added: danders; removed: anthonyfieroni. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: anthonyfieroni, danders Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

Re: D20400: Karbon: Enable multi page capability

2019-04-09 Thread René J . V . Bertin
> (Sorry for the inconvinience, I've never been very friendly with arc/phab) Understandable ;) Did you go the "official" route, committing your changes to a local branch and then using `arc diff` to create a review request? You probably should have used ` --update revision_id` . I always use u

D20400: Karbon: Enable multi page capability

2019-04-09 Thread Dag Andersen
danders added a comment. Ooops, this didn't work as expected. This should have been a revision of D19327 <https://phabricator.kde.org/D19327>. There is only small changes: 1. Updated commit message. 2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp too

D20400: Karbon: Enable multi page capability

2019-04-08 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. The main things that has changed

D19327: Karbon: Enable multi page capability

2019-03-07 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KarbonView.cpp:429-433 > +// TODO: It is not obvious how this is best implemented when importing > multipage docs > +// Append pages? > +// Append layers to existing pages? > +// Add shapes to active page? > +// etc? Ca

D19216: Karbon: Enable multi page capability

2019-03-07 Thread Dag Andersen
a more appropriate context. Ok, after another rethink... It starts to make sence if karbon is used not as an odg editor but as an svg editor. Let's say you create an icon that should be shown on certain background color(s), it would be a help if you could check your design ag

D19216: Karbon: Enable multi page capability

2019-02-28 Thread René J . V . Bertin
rjvbb added a comment. > That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown. Heh, I've had the opportunity to work closely with professional infographists so I picked up a thing or two about using applications like Illustrator and InDes

D19216: Karbon: Enable multi page capability

2019-02-28 Thread Camilla Boemann
asn't been sitting right with me and I finally realised why. > > That statement is true when you work with a real canvas and draw/paint/whatever directly onto that. If you take a grid paper the grid will become part of your art, but does Karbon print the grid which you can have it

D19216: Karbon: Enable multi page capability

2019-02-28 Thread René J . V . Bertin
k with a real canvas and draw/paint/whatever directly onto that. If you take a grid paper the grid will become part of your art, but does Karbon print the grid which you can have it show (except possibly via an option)? In drawing applications, the canvas is NOT part of your art, but simula

D19327: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. Ported to use pageapp classes

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: danders, anthonyfieroni Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Camilla Boemann
boemann added a comment. totally agree about not theme'ing canvas Also a general agreement to do the page app thing as long as it's also supported in svg odg is hardly that much of a reason - it even seems like odf is moving away from odg as much as possible REPOSITORY R8 Calligr

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
how). About me, i want them back, recent file complete remove not > commented. I reconsiddered this, sheets actually also implements this so I'll leave it in. (It does not work properly neither for karbon nor sheets, but that for different rainy day) > danders wrote in KarbonConfi

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders added a comment. In D19216#417502 , @rjvbb wrote: > > Canvas color: > > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. > > A custom canvas colour feat

D19216: Karbon: Enable multi page capability

2019-02-22 Thread René J . V . Bertin
rjvbb added a comment. > Canvas color: > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a de

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Anthony Fieroni
Ptr config = KSharedConfig::openConfig(); > +if (config->hasGroup("Interface")) { > +KConfigGroup interfaceGroup = config->group( "Interface" ); You can not check it, i think. Group will be empty if not present then readEntry fill return false. > danders wro

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > I want to discuss comments in the review, i don't want to have in. why we > remove this? Recent file & docker font: Why does karbon need these, none of the

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KarbonConfigInterfacePage.cpp:73-90 > +// TODO or move or remove? > +// m_recentFiles = new QSpinBox(tmpQGroupBox); > +// m_recentFiles->setRange(1, 20); > +// m_recentFiles->setSingleStep(1); > +// m_recentFiles->setValue(m_

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
IIRC it would just leave all other pages of the document alone). > > You should also test with PDF documents; in my experience Karbon 3.1 works well enough with them. Yes, pdf docs work, it is almost 100% handled by poppler. > ... > >> A lot of code was dupli

Re: D19216: Karbon: Enable multi page capability

2019-02-22 Thread René J . V . Bertin
ience Karbon 3.1 works well enough with them. >Ported to use pageapp classes. ... > A lot of code was duplicated between pageapp and karbon > and has been removed from karbon: Shouldn't that be a separate change - or does multi-page support come automatically with this change?

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support

karbon and multi page docs

2018-11-14 Thread Dag
@anthony I think karbon should be able to handle docs with more than one page as this is valid odf. This would also mean we can axe flow, as prev flow maintainer planned. What do you think? -- Cheers, Dag

D16721: Use Krita toolbar in Karbon

2018-11-10 Thread Ben Cooksley
bcooksley added a comment. Anyone who has already pulled in the latest changes will need to forcibly reset their local working tree after the force push is completed. Should they have staged work, this would need to be rebased, which can be a non-trivial process and one many developers will

D16721: Use Krita toolbar in Karbon

2018-11-10 Thread Anthony Fieroni
anthonyfieroni added a comment. In D16721#356863 , @bcooksley wrote: > Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? I really prefer to not have

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Ben Cooksley
bcooksley added a comment. Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, anthonyfieroni Cc: b

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Anthony Fieroni
as a next task in calligra/karbon that don't need to much knowledge about calligra internals? If you want we should export markers on svg 1.1, it's not easy, only if you have time and interest on. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D1672

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb added a comment. In D16721#356813 , @anthonyfieroni wrote: > Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write he

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R8:a7ee6f871af2: Use Krita toolbar in Karbon (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45181&id=45182 REVISION DETAIL h

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb updated this revision to Diff 45181. ognarb marked an inline comment as done. ognarb added a comment. Remove all whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45173&id=45181 BRANCH master REVISION DETAIL https://phabricator.

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb removed a reviewer: Krita. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, #krita Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
minSize.height() * 2 + spacing(), minSize.width()); > } Changed to just one row/column per default, because Karbon doesn't have for the moment a lot of tools :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb updated this revision to Diff 45173. ognarb marked 5 inline comments as done. ognarb added a comment. Fix REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45169&id=45173 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AF

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Anthony Fieroni
anthonyfieroni added a comment. Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :) INLINE COMMENTS > ognarb wrote in KoToolBoxDoc

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb added a comment. In D16721#356595 , @anthonyfieroni wrote: > Can you test my suggestions, it's looks good to me. Yes work also for me :) About the title bar for the dock, I'm not a fan of KoDockWidgetTitleBar for the tool bar

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan
ognarb updated this revision to Diff 45169. ognarb marked 9 inline comments as done. ognarb added a comment. Apply change according to review REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45113&id=45169 BRANCH master REVISION DETAIL https://p

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KoToolBoxLayout_p.h:310 > +private: > +int doLayout(const QRect &rect, bool notDryRun) const > { Also rename rect to size and QRect to QSize. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ogna

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Anthony Fieroni
anthonyfieroni added a comment. Can you test my suggestions, it's looks good to me. INLINE COMMENTS > ognarb wrote in KoToolBoxDocker.cpp:39 > I found out that this QLabel is, it's the small draggable zone at the top of > the docker. Actual it's still a bit b

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan
ognarb updated this revision to Diff 45113. ognarb added a comment. Revert a bit more REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45085&id=45113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan
ognarb added a comment. In D16721#356162 , @anthonyfieroni wrote: > Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 So I propose I add in a later diff the same confi

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Anthony Fieroni
anthonyfieroni added a comment. Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: anthonyfieroni, Callig

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan
ognarb marked 2 inline comments as done. ognarb added a comment. About the config for the KoKineticScroller. Do you perhaps know where to find the .kcfg file from calligra? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: a

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KoKineticScroller.cpp:28 > +{ > +KConfigGroup config = KSharedConfig::openConfig()->group(""); > +int sensitivity = config.readEntry("KineticScrollingSensitivity", 75); Let's have some name, KoKineticScroller or something. I also no

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
er. Actual it's still a bit buggy in krita and karbon F6397172: krita_toolbar_to.png <https://phabricator.kde.org/F6397172>. I should fix this before commiting. :D Edit: It's not a bug, it's a feature :D If I try to center the label, it's look a lot less good looking th

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45085. ognarb added a comment. Removing useless arg REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45082&id=45085 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widg

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45082. ognarb marked 8 inline comments as done. ognarb added a comment. Remove bad code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45031&id=45082 BRANCH master REVISION DETAIL https://phabricator.kde.or

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Anthony Fieroni
anthonyfieroni added a comment. Return QObjects, if you have problems copy linker output here. INLINE COMMENTS > KoToolBox.cpp:138 > button->setIconSize(QSize(iconSize, iconSize)); > -foreach (Section *section, d->sections) { > +foreach (Section *section, d->sections.values())

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb added a comment. In D16721#355367 <https://phabricator.kde.org/D16721#355367>, @anthonyfieroni wrote: > > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox > > I'm the m

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45031. ognarb marked 3 inline comments as done. ognarb added a comment. Fix some indentation problem REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45021&id=45031 BRANCH master REVISION DETAIL https://phabr

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45021. ognarb added a comment. Revert more change REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45020&id=45021 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widget

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45020. ognarb added a comment. Revert foreach and remove whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45018&id=45020 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED F

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45018. ognarb added a comment. Rever foreach REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45016&id=45018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets/CMa

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan
ognarb updated this revision to Diff 45016. ognarb marked an inline comment as done. ognarb added a comment. Revert some change more to come REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=44995&id=45016 BRANCH master REVISION DETAIL https://ph

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Anthony Fieroni
anthonyfieroni added a comment. > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox I'm the maintainer of Karbon, for now. Please revert foreach -> Q_FOREACH changes, it should be done in

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: Krita, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan
ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY I copied all KoToolBox* file and KissKineticScroller (renamed to KoKineticScroller) from Krita repo. TEST PLAN Compi

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

2018-10-18 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:99527b565f59: Karbon: Add Anthony as maintainer and remove unmaintained (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16289?vs=43840&id=4

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

2018-10-18 Thread Anthony Fieroni
anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH karbon_danders REVISION DETAIL https://phabricator.kde.org/D16289 To: danders, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

2018-10-17 Thread Dag Andersen
://phabricator.kde.org/D16289 AFFECTED FILES karbon/ui/KarbonAboutData.h To: danders, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

Karbon and import from Illustrator

2017-01-10 Thread René J . V . Bertin
Hi, I've been making my first steps getting Karbon to build on Mac. There's an issue with QStandardPaths in one of the central KO libraries that I'll need to address properly but that shouldn't be too hard. My current question is about import from Adobe Illustrator. For

  1   2   3   >