anthonyfieroni added a comment.
Thank you, i should wait ship it, but just got Dag comment as it is.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcalis
leinir added a comment.
Incidentally, while this was committed before i could test it, i can confirm
that it works fine with Calligra Gemini
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: leinir, Calligr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:2258d76ae064: Fix canvas event handling (authored by
anthonyfieroni).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.
anthonyfieroni added a comment.
Seems fine, i'll push pageapp/flake changes as part of this review in 3.2
branch and master, refactoring main window in separate commit master only.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, dan
danders added a comment.
This seems to work fine, I also tested with only pageapp changes.
Imho I would prefer to separate the pageapp and KoMainWindow changes into
separate commits,
The pageapp changes should go into 3.2 branch followed by a swift release.
I don't think the KoMainWindow
anthonyfieroni updated this revision to Diff 82646.
anthonyfieroni added a comment.
@danders i saw you patch on my email.
`d->viewportWidget->canvas()->removeEventFilter(this);` fixes the issue but i
still prefer all of refactoring code. Please test on all components does not
have regression
anthonyfieroni retitled this revision from "Refactor MainWindow view" to
"Refactor canvas event handling".
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D29542
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, o
