D29542: Refactor MainWindow view

anthonyfieroni added a comment. We should call `removeEventFilter` or found exactly why signal is emitted in destructor. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellyn

D29542: Refactor MainWindow view

danders added a comment. In D29542#668076 , @anthonyfieroni wrote: > `d->rootPart->createView(doc, this);` Creates the view which parent is main window. Ahh, yes, but then... Why will it not crash if a new document is set so that d->

D29542: Refactor MainWindow view

anthonyfieroni added a comment. `d->rootPart->createView(doc, this);` Creates the view which parent is main window. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones

D29542: Refactor MainWindow view

danders added a comment. Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have not tested, I might be wrong) Afaics the problem is that a focus event is issued that accesses the view after death. Possibly a deleteLater() would do it, but I tried with setting paret

D29542: Refactor MainWindow view

anthonyfieroni updated this revision to Diff 82337. anthonyfieroni added a comment. Add more context REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29542?vs=82301&id=82337 REVISION DETAIL https://phabricator.kde.org/D29542 AFFECTED FILES libs/main/KoMa

D29542: Refactor MainWindow view

anthonyfieroni created this revision. anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY CCBUG: 421083 It looks like there