D29242: WIP: redesign sidebar

ognarb abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb, boemann Cc: Imerion, anthonyfieroni, boemann, Calligra-Devel-list, blu-base, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

Imerion added a comment. In D29242#658883 , @boemann wrote: > Well you are definitely in the right class to make such changes. > > The thing is the current code was made to adopt to many different user wishes - so the user could choose >

D29242: WIP: redesign sidebar

anthonyfieroni added inline comments. INLINE COMMENTS > calligrawords.rc:2 > > > Increase version. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb,

D29242: WIP: redesign sidebar

ognarb updated this revision to Diff 81490. ognarb added a comment. - More work in progress change TODO - don't make KoModeBox public - Implement add shapes action - Figure out how to draw line seperator - Fix some issues found when applying the Breeze ToolArea patch REPOSITORY

D29242: WIP: redesign sidebar

anthonyfieroni added a comment. > The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it). I think it can be

D29242: WIP: redesign sidebar

ognarb planned changes to this revision. ognarb added a comment. In D29242#658883 , @boemann wrote: > Well you are definitely in the right class to make such changes. > > The thing is the current code was made to adopt to many different user

D29242: WIP: redesign sidebar

anthonyfieroni added a comment. I don't know everyone wants tools to be above edit window. That's pretty old stile when resolution was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed. INLINE COMMENTS > KoModeB

D29242: WIP: redesign sidebar

boemann added a comment. Well you are definitely in the right class to make such changes. The thing is the current code was made to adopt to many different user wishes - so the user could choose What you are doing is to throw all that away - would it be impossible to have this new

D29242: WIP: redesign sidebar

ognarb added a comment. There is a mockup here: T12837 this is really WIP I just created the diff because I asked someone to help me with a part of the code and I needed to show them the code. REPOSITORY R8 Calligra REVISION DETAIL https://phabricato

D29242: WIP: redesign sidebar

boemann added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb, boemann Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

boemann added a comment. My immidiate reaction is no. Do you mind sharing a screenshot / drawing of what the end goal is here ? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognar

D29242: WIP: redesign sidebar

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REPOSITORY R8 Calligra BRANCH redesign REVISION DETAIL https://phabricator.kde.org/D29242 AFFECTED FILES libs/widgets/KoModeBox.