danders abandoned this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D2577
To: danders, #calligra:_3.0, staniek, Calligra-Devel-list
Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman,
cochise, vandenoever
danders added a comment.
The background was it failed for one case in Plan, and I found a possible
failure in KoMainWindow (I think it was), but that was a "if all else fails"
case and I doubt the code will ever be executed.
Also, I have seen that not all places uses KoResourcePaths so a ca
anthonyfieroni added a comment.
This revision now requires changes to proceed.
This review is more than an years old, is it still related?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D2577
To: danders, #calligra:_3.0, staniek, Calligra-Devel-list
Cc: anthonyfieroni
staniek added inline comments.
INLINE COMMENTS
> danders wrote in KoResourcePaths.cpp:43
> I did it to be able to filter out all other debug statements, and I can see
> where it originates so I find it much easier to use.
I did it to be able to filter out all other debug statements, and I can s
danders updated this revision to Diff 6382.
danders marked an inline comment as done.
danders added a comment.
KoResourcePaths: Fix review comments
- Use COMPILING_TESTS instead of NDEBUG
- Variable l -> location
- Improve api docs, fix typos
- Fix debug according to norm
danders marked 4 inline comments as done.
danders added inline comments.
INLINE COMMENTS
> staniek wrote in KoResourcePaths.cpp:47
> Isn't the modern like this?
>
> // in a header
> Q_DECLARE_LOGGING_CATEGORY(driverUsb)
>
> // in one source file
> Q_LOGGING_CATEGORY(driverUsb, "driver.usb")
Re
danders marked 4 inline comments as done.
danders added a comment.
Fixed some of your comments, I'll wait for more before updating.
INLINE COMMENTS
> staniek wrote in KoResourcePaths.cpp:43
> Can we drop the "ko" legacy here?
>
> Or even: do we really need a category per class/namespace or p
staniek requested changes to this revision.
staniek added a reviewer: staniek.
This revision now requires changes to proceed.
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D2577
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
staniek added a comment.
Nice, some early notes.
INLINE COMMENTS
> KoResourcePaths.cpp:43
> +{
> +static const QLoggingCategory
> category("calligra.lib.widgets.koresourcepaths");
> +return category;
Can we drop the "ko" legacy here?
Or even: do we really need a category per class/
staniek added a reviewer: Calligra-Devel-list.
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D2577
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: danders, #calligra:_3.0, Calligra-Devel-list
Cc: staniek
10 matches
Mail list logo
