D24852: Remove list style from headings

ognarb closed this revision. ognarb added a comment. Merged REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders Cc: ognarb, danders, anthonyfieroni, boemann, Calligra-Devel-list, blu-base, davidllewellynjone

D24852: Remove list style from headings

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Most seems to be positive, so go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders Cc: dande

D24852: Remove list style from headings

pvuorela added a comment. Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141 But the rationale sounds good to me, fixes the issue and no

D24852: Remove list style from headings

anthonyfieroni added a comment. +1, i'm ok with that. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

akomakhin updated this revision to Diff 69568. akomakhin added a comment. OK, let's set formatSpecification explicitly to Empty if "num-format" value is empty. OASIS 1.2 says, in cases "an empty string" or "no value" is given, then no number sequence is displayed. REPOSITORY R8 Calligra C

D24852: Remove list style from headings

akomakhin added a comment. According to this is it correct to set formatSpecification to Empty if "num-format" value is empty in all lists, not only in headings? REPOSITORY R8 Calli

D24852: Remove list style from headings

boemann added a comment. Not strange for a normal list - but yes for headings it sounds wrong - and I think this is where you need to make the changes. So if in load odf you are loading a heading and it doesn't specify numbering set it formatspecification to empty. But please make s

D24852: Remove list style from headings

akomakhin added a comment. But there is a simple statement in loadOdf function: if "num-format" is empty, then formatSpecification has a default value -- Numeric style. Isn't it strange, assuming all list styles numerical? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.o

D24852: Remove list style from headings

boemann added a comment. This looks scarily generic What happens when the user via gui adds a numbered lists, and what is the impact in the other applications You are definitely on to something with formatSpecification, but maybe not setting is for all but only when loading headers

D24852: Remove list style from headings

akomakhin updated this revision to Diff 69451. akomakhin edited the summary of this revision. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24852?vs=68509&id=69451 REVISION DETAIL https://phabricator.kde.org/D24852 AFFECTED FILES libs/odf/KoOdfNumberDefin

D24852: Remove list style from headings

anthonyfieroni added a comment. I think `add` should be conditional. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

akomakhin added a comment. In D24852#553906 , @boemann wrote: > All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case Interesting: saving document with numbered, and

D24852: Remove list style from headings

boemann added a comment. All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: boemann,

D24852: Remove list style from headings

akomakhin added a comment. In D24852#552012 , @boemann wrote: > I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases list->add(block, level); is called ever

D24852: Remove list style from headings

boemann added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

boemann added a comment. I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: boemann,

D24852: Remove list style from headings

akomakhin edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

akomakhin created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. akomakhin requested review of this revision. REVISION SUMMARY F7645960: Снимок_Экрана_20191001_001.png Bug description: headings ar

D24852: Remove list style from headings

akomakhin added reviewers: pvuorela, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever