This revision was automatically updated to reflect the committed changes.
Closed by commit R8:11b3b7718796: Add support for strikeout text in RTF
documents (authored by pvuorela).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24830?vs=68442&id=68516
REVISION
pvuorela accepted this revision.
pvuorela added a comment.
This revision is now accepted and ready to land.
Looking good to me.
REVISION DETAIL
https://phabricator.kde.org/D24830
To: akomakhin, pvuorela, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
boemann added a comment.
As far as I'm concerned you may push to rtf importer at your own discretion
REVISION DETAIL
https://phabricator.kde.org/D24830
To: akomakhin, pvuorela, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
akomakhin marked an inline comment as done.
REVISION DETAIL
https://phabricator.kde.org/D24830
To: akomakhin, pvuorela, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
akomakhin updated this revision to Diff 68442.
akomakhin added a comment.
Fixed set value from "true" to expression " ! hasValue || ( hasValue && value
!= 0 ) "
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24830?vs=68436&id=68442
REVISION DETAIL
https://phabricator.kde.org/D248
pvuorela added inline comments.
INLINE COMMENTS
> DocumentDestination.cpp:121
> + } else if ( controlWord == "strike" ) {
> + m_output->setFontStrikeout(true);
> } else if ( ( controlWord == "u" ) && hasValue ) {
Value should be like bold and underline, i.e. something like "! h
akomakhin created this revision.
akomakhin added reviewers: pvuorela, Calligra: 3.0.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
akomakhin requested review of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24830
A
