This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e80856e8eb6a: Asign correct column width when importing XLS
file (authored by davidllewellynjones, committed by pvuorela).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
davidllewellynjones updated this revision to Diff 68959.
davidllewellynjones added a comment.
Thanks here also @dcaliste. This is all a bit confusing I agree and deserves
some explanation. I've added in something along the lines you suggested, which
I think helps (your insight that the scalin
dcaliste added a comment.
Well, after reading the difference between the logical and physical DPI
values:
https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt
(see the first answer), using the logical value is consistent with the hard
pvuorela accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24761
To: davidllewellynjones, #calligra:_3.0, pvuorela
Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
pvuorela added a comment.
Seems it was indeed the only physicalDpi, though not too many logical either.
Not trivial to follow, but seems sane and the screenshots are thorough. I'll
approve if no-one objects shortly.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D247
davidllewellynjones edited the test plan for this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24761
To: davidllewellynjones, #calligra:_3.0, pvuorela
Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
davidllewellynjones added reviewers: Calligra: 3.0, pvuorela.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D24761
To: davidllewellynjones, #calligra:_3.0, pvuorela
Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
davidllewellynjones created this revision.
davidllewellynjones added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
davidllewellynjones requested review of this revision.
REVISION SUMMARY
When importing an Excel 97-2003 .xls file (using the excel importer) the
column