This revision was automatically updated to reflect the committed changes.
Closed by commit R8:f0f0eedf1e74: Correct anchor detection in QML components.
(authored by dcaliste).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23492?vs=65201&id=65245
REVISION DETA
pvuorela added a comment.
And even rendering now better, no idea what happened.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D23492
To: dcaliste, leinir, pvuorela, danders, boemann
Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever
pvuorela accepted this revision.
pvuorela added a comment.
Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the
raw diff looks good now. Trust all good :)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D23492
To: dcaliste, leinir, pvuorela, d
dcaliste updated this revision to Diff 65201.
dcaliste added a comment.
Thank you pvuorela pointing out other places for this construct. I've updated
the patch with a fix for the faulty loops for spreadsheets and presentations
also.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Oh dear, yes, took a moment. Well spotted indeed!
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D23492
To: dcaliste, leinir, pvuorela, danders, boemann
Cc: Calligr
pvuorela added a comment.
Indeed that doesn't look like a good loop, if triggered once, nothing
affecting the break out condition inside of it. But isn't the same thing
happening also at the beginning of this method, and actually same kind of
construct being there in spreadsheet and presenta
dcaliste created this revision.
dcaliste added reviewers: leinir, pvuorela, danders, boemann.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.
REVISION SUMMARY
The loop to translate the anchor shape position in T
