D23202: Fix headers for >=KCalCore-5.12.0

asturmlechner abandoned this revision. asturmlechner added a comment. In D23202#513068 , @vkrause wrote: > see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here Yes, I was being blind. > But that lea

D23202: Fix headers for >=KCalCore-5.12.0

vkrause added a comment. Version header backward compatibility addressed in D23204 . REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23202 To: asturmlechner, #calligra:_3.0, dfaure, vkrause Cc: Calligra-Devel-list, dcaliste, cochis

D23202: Fix headers for >=KCalCore-5.12.0

vkrause added a comment. see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here But that leaves the problem of the version header, we also need to install that with the old name I think. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde

D23202: Fix headers for >=KCalCore-5.12.0

asturmlechner added a comment. In D23202#513056 , @vkrause wrote: > This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility? That does not seem to be the case on my system,

D23202: Fix headers for >=KCalCore-5.12.0

vkrause added a comment. This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23202 To: asturmlechner, #calligra:_3.0, dfaure, vkrause Cc: Calligra-D

D23202: Fix headers for >=KCalCore-5.12.0

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > icalendarexport.cpp:30 > > +#if KCALCORE_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +#include You can't test for the version number before including kcal[end

D23202: Fix headers for >=KCalCore-5.12.0

dfaure added a reviewer: vkrause. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23202 To: asturmlechner, #calligra:_3.0, dfaure, vkrause Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D23202: Fix headers for >=KCalCore-5.12.0

asturmlechner created this revision. asturmlechner added reviewers: Calligra: 3.0, dfaure. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. asturmlechner requested review of this revision. REPOSITORY R8 Calligra BRANCH kcalcore-5.12.0 REVISION DETAIL h