This revision was automatically updated to reflect the committed changes.
Closed by commit R8:35ec7cff51c2: Small cleanups for qml components (authored
by pvuorela).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19943?vs=54489&id=55405
REVISION DETAIL
https
leinir accepted this revision.
leinir added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> pvuorela wrote in Document.cpp:221
> Nothing, but that's how it used to be. The intention might have been
> different, but effectively it's two disconnects without actu
pvuorela added inline comments.
INLINE COMMENTS
> leinir wrote in Document.cpp:221
> What happens to this signal now?
Nothing, but that's how it used to be. The intention might have been different,
but effectively it's two disconnects without actual connection appearing
anywhere as far as I ca
leinir added inline comments.
INLINE COMMENTS
> Document.cpp:221
> -if (d->textEditor) {
> -disconnect(d->textEditor, SIGNAL(cursorPositionChanged()), this,
> SIGNAL(selectionChanged()));
> -}
What happens to this signal now?
REPOSITORY
R8 Calligra
REVISION DETAI
pvuorela created this revision.
pvuorela added a reviewer: leinir.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
pvuorela requested review of this revision.
REVISION SUMMARY
- Delete doesn't need null protection
- Removed some non-functional texteditor
