D19132: Update libs/widgets to c++11

This revision was automatically updated to reflect the committed changes. Closed by commit R8:c32f7ef9bbbf: Update libs/widgets to c++11 (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52121&id=52341 REVISION DETAIL https://phab

D19132: Update libs/widgets to c++11

danders added a comment. > Thanks for the review, I will work next on libs/{pigment,version,widgetutils}. Hmm, maybe wait with pigment, according to rempt, only krita actually used it. I haven't looked into it, but if that is the case probably we should dump it. REPOSITORY R8 Calligr

D19132: Update libs/widgets to c++11

ognarb added a comment. In D19132#416519 , @danders wrote: > Ok, I can't say I have scrutinized every change, but... > Could you give a heads up when you continue with other parts or else there may be merge problems. > I'm working on karbon

D19132: Update libs/widgets to c++11

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Ok, I can't say I have scrutinized every change, but... Could you give a heads up when you continue with other parts or else there may be merge problems. I'm working on karbon and page

D19132: Update libs/widgets to c++11

ognarb updated this revision to Diff 52121. ognarb added a comment. Fix build REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52119&id=52121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19132 AFFECTED FILES CMakeLists.txt lib

D19132: Update libs/widgets to c++11

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb updated this revision to Diff 52119. ognarb added a comment. - Revert foreach modifications - Fix some forgotten 0 as nullptr instances REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52008&id=52119 BRANCH master REVISION DETAIL https:

D19132: Update libs/widgets to c++11

leinir added a comment. There is an issue with Qt's foreach, however if the author would be so nice as to check that this version using C++11 iteration does not break building on Windows, then it can go in... Though, yes, it most certainly wants testing, and i don't currently have a function

D19132: Update libs/widgets to c++11

danders added a reviewer: leinir. danders added a comment. Hmmm. wasn't it somethng with ms windows and for loops, leinir? Also, I think there may be detachment issues with them, clazy can tell. There is a qAsConst() solution but that is not supported in the qt version we need to support.

D19132: Update libs/widgets to c++11

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Use clang-tidy to: - Use default wenn possible for constructor and destructor - Use nullptr instead of 0 or NULL