D18963: Improve KoModeBox display in horizontal Mode

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

This revision was automatically updated to reflect the committed changes. Closed by commit R8:ede08705548e: Improve KoModeBox display in horizontal Mode (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51594&id=51596 REVISION DETAI

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51594. ognarb added a comment. remove more trailing whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51589&id=51594 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51589. ognarb added a comment. remove trailing whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51523&id=51589 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES lib

D18963: Improve KoModeBox display in horizontal Mode

danders added a comment. Please remove trailing whitespace. REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, co

D18963: Improve KoModeBox display in horizontal Mode

ognarb added a comment. Ok thanks for the review, I will retry to compile calligra master and see if it's still work and then land this diff. 😄 REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc:

D18963: Improve KoModeBox display in horizontal Mode

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. I like it REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: boemann, anthonyfieroni, abet

D18963: Improve KoModeBox display in horizontal Mode

anthonyfieroni added a comment. It's good to +1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

abetts added a comment. In D18963#410791 , @ngraham wrote: > The first image is the new version, not the old version. :) Oh good! I was confused. Thank you REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D1896

D18963: Improve KoModeBox display in horizontal Mode

ngraham added a comment. The first image is the new version, not the old version. :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

abetts added a comment. It is pretty rough. It works, but needs better looks. The toolbar section now takes up almost half of the screen. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: abetts, ngraham, Calligra-Devel-list,

D18963: Improve KoModeBox display in horizontal Mode

ngraham accepted this revision as: VDG. ngraham added a comment. Certainly a visual improvement! +1! Wait for code review before landing, of course. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: ngraham, Calligra-Devel

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51523. ognarb added a comment. Remove debug output REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51522&id=51523 BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES libs

D18963: Improve KoModeBox display in horizontal Mode

ognarb edited the summary of this revision. ognarb added reviewers: Calligra: 3.0, VDG. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Use less vertical space, don't change anything in vertical Mode TEST PLAN Compile, run, no bug found yet :D. Not