D18095: Add new table layout unit tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:666ae5b484cc: Add new table layout unit tests (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE

D18095: Add new table layout unit tests

boemann added a comment. absolutely REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

danders added a comment. Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calli

D18095: Add new table layout unit tests

danders updated this revision to Diff 49141. danders added a comment. Add a test that trigger a loop in the table layout REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18095?vs=48957&id=49141 BRANCH table_unittest_danders REVISION DETAIL https://phabri

D18095: Add new table layout unit tests

danders added a comment. No, all do not pass, generally when the first row is merged, layout fails. (I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428 .) REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18095: Add new table layout unit tests

boemann added a comment. Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed I'll think about further tests REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Callig

D18095: Add new table layout unit tests

danders added a comment. Not trivial (for me) to get data out of layout so it is hard to create robust tests. I don't think I have been able to create a test to simulate the loop excactly. Also, uncertain wether the MockRootAreaProvider is sufficient. Any ideas/comments wellcome. REPOSI

D18095: Add new table layout unit tests

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds multiple areas capabilities and tests with merged cells REPOSI