D16721: Use Krita toolbar in Karbon

bcooksley added a comment. Anyone who has already pulled in the latest changes will need to forcibly reset their local working tree after the force push is completed. Should they have staged work, this would need to be rebased, which can be a non-trivial process and one many developers will

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. In D16721#356863 , @bcooksley wrote: > Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? I really prefer to not have

D16721: Use Krita toolbar in Karbon

bcooksley added a comment. Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, anthonyfieroni Cc: b

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a subscriber: bcooksley. anthonyfieroni added a comment. Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them. > That do you recommend as a

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356813 , @anthonyfieroni wrote: > Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write he

D16721: Use Krita toolbar in Karbon

This revision was automatically updated to reflect the committed changes. Closed by commit R8:a7ee6f871af2: Use Krita toolbar in Karbon (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45181&id=45182 REVISION DETAIL https://phabr

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45181. ognarb marked an inline comment as done. ognarb added a comment. Remove all whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45173&id=45181 BRANCH master REVISION DETAIL https://phabricator.

D16721: Use Krita toolbar in Karbon

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write

D16721: Use Krita toolbar in Karbon

ognarb removed a reviewer: Krita. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, #krita Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356755 , @anthonyfieroni wrote: > Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45173. ognarb marked 5 inline comments as done. ognarb added a comment. Fix REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45169&id=45173 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AF

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :) INLINE COMMENTS > ognarb wrote in KoToolBoxDoc

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356595 , @anthonyfieroni wrote: > Can you test my suggestions, it's looks good to me. Yes work also for me :) About the title bar for the dock, I'm not a fan of KoDockWidgetTitleBar for the tool bar

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45169. ognarb marked 9 inline comments as done. ognarb added a comment. Apply change according to review REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45113&id=45169 BRANCH master REVISION DETAIL https://p

D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoToolBoxLayout_p.h:310 > +private: > +int doLayout(const QRect &rect, bool notDryRun) const > { Also rename rect to size and QRect to QSize. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ogna

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you test my suggestions, it's looks good to me. INLINE COMMENTS > ognarb wrote in KoToolBoxDocker.cpp:39 > I found out that this QLabel is, it's the small draggable zone at the top of > the docker. Actual it's still a bit buggy in krita and karbon F6397172

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45113. ognarb added a comment. Revert a bit more REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45085&id=45113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356162 , @anthonyfieroni wrote: > Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 So I propose I add in a later diff the same confi

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: anthonyfieroni, Callig

D16721: Use Krita toolbar in Karbon

ognarb marked 2 inline comments as done. ognarb added a comment. About the config for the KoKineticScroller. Do you perhaps know where to find the .kcfg file from calligra? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: a

D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoKineticScroller.cpp:28 > +{ > +KConfigGroup config = KSharedConfig::openConfig()->group(""); > +int sensitivity = config.readEntry("KineticScrollingSensitivity", 75); Let's have some name, KoKineticScroller or something. I also no

D16721: Use Krita toolbar in Karbon

ognarb marked 3 inline comments as done. ognarb added a comment. In D16721#355600 , @anthonyfieroni wrote: > Return QObjects, if you have problems copy linker output here. `make clean` solved the issue INLINE COMMENTS > anthonyfieroni w

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45085. ognarb added a comment. Removing useless arg REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45082&id=45085 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widg

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45082. ognarb marked 8 inline comments as done. ognarb added a comment. Remove bad code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45031&id=45082 BRANCH master REVISION DETAIL https://phabricator.kde.or

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Return QObjects, if you have problems copy linker output here. INLINE COMMENTS > KoToolBox.cpp:138 > button->setIconSize(QSize(iconSize, iconSize)); > -foreach (Section *section, d->sections) { > +foreach (Section *section, d->sections.values())

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#355367 , @anthonyfieroni wrote: > > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox > > I'm the maintainer of Karbon, for now.

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45031. ognarb marked 3 inline comments as done. ognarb added a comment. Fix some indentation problem REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45021&id=45031 BRANCH master REVISION DETAIL https://phabr

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45021. ognarb added a comment. Revert more change REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45020&id=45021 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widget

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45020. ognarb added a comment. Revert foreach and remove whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45018&id=45020 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED F

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45018. ognarb added a comment. Rever foreach REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45016&id=45018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets/CMa

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45016. ognarb marked an inline comment as done. ognarb added a comment. Revert some change more to come REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=44995&id=45016 BRANCH master REVISION DETAIL https://ph

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox I'm the maintainer of Karbon, for now. Please revert foreach -> Q_FOREACH changes, it should be done in separate patch. Clea

D16721: Use Krita toolbar in Karbon

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb edited the summary of this revision. ognarb added reviewers: Krita, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY I copied all KoToolBox* file and KissKineticScroller (renamed to KoKineticScroller) from Krita repo. TEST PLAN Compi