D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-29 Thread Dag Andersen
danders abandoned this revision. danders added a comment. Ok, after some more investigation, I've found a number of problems around these things. This was really just a bug in the stencil database.odg file. The callout stuff is the big one, because it abuses odf so needs special treatment

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-23 Thread Dag Andersen
danders added a comment. Yes, found it: https://bugs.kde.org/show_bug.cgi?id=289646 Afaics this affects only callout shapes where OO/LO breaks the intention of the odf spec by using the shape size and position as text area. This is ok (sort of) when text area and shape area overlap but n

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Camilla Boemann
boemann added a comment. As I recall it was one of the files in the huge dataset - there should be a bug on it REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16367 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Dag Andersen
danders added a comment. I have tested with LO: Create with flow, Open in LO, Save in LO, Open in flow. And it seems to work, so there must be some special case? The only workaround I've seen is for ellipses. No chance for a testdoc I guess... REPOSITORY R8 Calligra REVISION D

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Camilla Boemann
boemann added a comment. Yes as i recall that code was made to handle masks being exported correctly for OpenOffice or LO - I'd strongly prefer it not being thrown away like that REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16367 To: danders, boemann, anthonyfier

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Anthony Fieroni
anthonyfieroni added a comment. When i investigate to find out why it's saved square not rectangle i suspect that code, but i'm still not absolutely sure that it's wrong. Maybe @boemann knows better. If so can we remove m_viewBound as well? REPOSITORY R8 Calligra REVISION DETAIL https:/

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Remove all code that uses viewbox to affect position and size.