This revision was automatically updated to reflect the committed changes.
Closed by commit R8:4ebf41d68d71: Replace deprecated use of
QWeakPointer in favor of QPointer (authored by
dcaliste).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
In that case, things build and run fine for me, and while i can't comment on
performance here, i understand that making QPointer sufficiently performant was
basically why QWeakPointer was d
boemann added a comment.
I have no fundamentally against it, but I cannot test it right - so if it
works 'm all for it
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15103
To: dcaliste, #calligra:_3.0, leinir, danders, boemann
Cc: Calligra-Devel-list, cochise, vande
leinir added a reviewer: boemann.
leinir added a comment.
Adding in Camilla, because text :)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15103
To: dcaliste, #calligra:_3.0, leinir, danders, boemann
Cc: Calligra-Devel-list, cochise, vandenoever
dcaliste added reviewers: leinir, danders.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15103
To: dcaliste, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, cochise, vandenoever
dcaliste updated this revision to Diff 40514.
dcaliste added a comment.
Propagate changes into filters: missing conversion from QSharedPointer into
QPointer.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15103?vs=40513&id=40514
REVISION DETAIL
https://p
dcaliste created this revision.
dcaliste added a reviewer: Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.
REVISION SUMMARY
QWeakPointer has been deprecated to store pointers on QObject. QPointer