D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. Thank you all for the review. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

This revision was automatically updated to reflect the committed changes. Closed by commit R8:560701ff2443: Consistently use qreal in libs/pigment (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15053?vs=40892&id=43312 REVISION DETAIL

D15053: Consistently use qreal in libs/pigment

danders accepted this revision as: danders. danders added a comment. This revision is now accepted and ready to land. Fine with me. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calligr

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a subscriber: boemann. anthonyfieroni added a comment. I'm OK with it +1, @danders or @boemann should accept it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calli

D15053: Consistently use qreal in libs/pigment

leinir added a comment. @dcaliste @anthonyfieroni Any updates here, pro/con? Would be a terrible shame to let this fall through :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-l

D15053: Consistently use qreal in libs/pigment

leinir added a comment. This is looking pretty good to me, really... i know there was talk about deprecating qreal at some point, but turns out that never happened? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc

D15053: Consistently use qreal in libs/pigment

dcaliste updated this revision to Diff 40892. dcaliste added a comment. Update the patch not to use the form ```qBound(qreal(0.0), a, qreal(1.0))``` but ```qBound(0.0, a, 1.0)``` instead. For reference, original form was ```qBound(0.0, a, 1.0)``` which was causing issues when qreal <-> float,

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. In D15053#314717 , @dcaliste wrote: > I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. I will investigate to remove it as depend. REPOSITORY R8 Calligra

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64. I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. But at least, proposed patch makes PART_WORDS and PART_STAGE compilable when qreal <=> fl

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. Ok, I'll try in the afternoon or during the week-end and comment here. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. I'm OK with the patch, can you try Karbon as well? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading Calligra there to latest version. @leinir have done it earlier with version 2.9.x. At that moment, pigment was not containing that kind of function to change luminosity... where the conversions ar

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. You use it on Pinebook or similar ARM based laptop? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY On my ARM environment, qreal is interpreted as float, no