This revision was automatically updated to reflect the committed changes.
Closed by commit R8:fe471acca71b: Don't use obsolete QRectF and
QAbstractItemModel functions (authored by dcaliste).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14975?vs=40193&id=41961#toc
REPOSITORY
R8 Callig
danders accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D14975
To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever
dcaliste updated this revision to Diff 40193.
dcaliste added a comment.
Update the patch in stackChanged() call to have the exact behaviour than
before in this method.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14975?vs=40152&id=40193
REVISION DETAIL
https://phabricator.kde.o
dcaliste added a comment.
@danders I agree with your remark, I was wondering exactly the same. It's
safer to put the begin / end together. I'll update the diff and add a comment
to suggest to move the end after the setCurrentIndex() after extensive testing.
REVISION DETAIL
https://phabrica
danders added a comment.
I'm not 100% sure of stackChanged() change.
Probably ok, but the original would call both begin and end before calling
the selection model.
To get exactly the same behaviour you could do the same.
It depends on how the selction model handles reset and setCurrentI
dcaliste retitled this revision from "Don't use obsolete QRectF functions" to
"Don't use obsolete QRectF and QAbstractItemModel functions".
REVISION DETAIL
https://phabricator.kde.org/D14975
To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandeno
