This revision was automatically updated to reflect the committed changes.
Closed by commit R8:f5a88ba9040e: [ArtisticTextShape] Merge text ranges with
same style (authored by anthonyfieroni).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14916?vs=40031&id=4014
danders accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D14916
To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever
anthonyfieroni updated this revision to Diff 40031.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14916?vs=39955&id=40031
REVISION DETAIL
https://phabricator.kde.org/D14916
AFFECTED FILES
plugins/artistictextshape/ArtisticTextShape.cpp
To: anthonyfieroni
anthonyfieroni added a comment.
You are right, when i see docs
> /// Appends plain text to the last text range
> void appendText(const QString &plainText);
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D14916
To: anthonyfieroni, boemann, danders, #calligra:_3
danders added a comment.
Hmm, I assumed it only got in here when appending a text to
a) an empty shape (no need for merging),
b) at the end of an existing text, in which case using the the existing
formatting of the last range should ok. I just can't see why using a
defaultfont in this ca
anthonyfieroni added a comment.
Basically we want to be unchanged, but when it merged, now, it does not have
guaranteed that appending to last will be nor same behavior nor correct.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D14916
To: anthonyfieroni, boemann, da
danders added a comment.
The change in appendText(const QString &text):
The original appended to an existing range while you add a new range.
I would think you could just leave the old code untouched, no?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D14916
To:
anthonyfieroni created this revision.
anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
anthonyfieroni requested review of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabri
