This revision was automatically updated to reflect the committed changes.
Closed by commit R8:705d0ae50923: Fix blocklayout unittest after percentage
lineheight was fixed in D9537 (authored by danders).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14901?vs=39919&id=40803#toc
REPOSITORY
boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.
I like what you have done - you seem to understand the concepts, so please
commit when you feel like it's working
INLINE COMMENTS
> TestBlockLayout.cpp:333
> //qDebug() << blockLay
danders added a comment.
Ping?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D14901
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever
danders marked an inline comment as done.
danders added a comment.
What to change depends on what the number means ;)
Well in general all numbers that depends on fontsize should be changed, the
rest should stay the same, but yes it is a puzzle.
REPOSITORY
R8 Calligra
REVISION DETAIL
ht
anthonyfieroni added a comment.
Thanks, i really don't know how to change predefined values like 28.0 etc. i
see you changed them i still not clear to me what are the new vales :)
INLINE COMMENTS
> TestBlockLayout.cpp:497
> int lastLineNum = block1Layout->lineCount() - 1;
> -const q
danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.
REVISION SUMMARY
There is a couple of failing tests now marked as XFAIL.
I am afrai
