Re: Review Request: Configuration dialogs for Calligra Applications

2011-01-19 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100406/#review992 --- libs/main/KoConfigurationDialogPage.h

Re: Review Request: Configuration dialogs for Calligra Applications

2011-01-17 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100406/ --- (Updated Jan. 17, 2011, 5:46 p.m.) Review request for Calligra. Changes

Re: Review Request: Configuration dialogs for Calligra Applications

2011-01-17 Thread Cyrille Berger Skott
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100406/#review948 --- It looks like it is going in the right direction. However: * I th

Review Request: Configuration dialogs for Calligra Applications

2011-01-17 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100406/ --- Review request for Calligra. Summary --- Currently there is no standa

Re: Configuration dialogs for Calligra Applications

2011-01-14 Thread Shantanu Tushar Jha
Hi, I spent few days working on this and have created a configuration dialog in KoView with a virtual method which can be overridden by derived classes (for example, Table's part/View) to add their additional custom pages. I have attached a patch that adds the common configuration dialog to libs/

Re: Configuration dialogs for Calligra Applications

2011-01-13 Thread Shantanu Tushar Jha
Hi all, We had a discussion on IRC about this (mainly with Boemann and Cyrille) and we reached an agreement that the shared configuration dialogs can be implemented using the same way tables does it using tables/part/dialogs/PreferenceDialog. So the idea is to have a PreferenceDialog in libs/

Re: Configuration dialogs for Calligra Applications

2011-01-12 Thread Thorsten Zachmann
On Thursday, January 13, 2011 07:43:36 Shantanu Tushar Jha wrote: > Hi, > I am a new contributor to Calligra and was trying to resolve > https://bugs.kde.org/show_bug.cgi?id=260516 . I found while discussing on > IRC that the feature is already implemented, and only configuration options > are

Configuration dialogs for Calligra Applications

2011-01-12 Thread Shantanu Tushar Jha
Hi, I am a new contributor to Calligra and was trying to resolve https://bugs.kde.org/show_bug.cgi?id=260516 . I found while discussing on IRC that the feature is already implemented, and only configuration options are missing in Words (but are present in Stage, Tables etc). Now, If I try to a