danders updated this revision to Diff 6382.
danders marked an inline comment as done.
danders added a comment.
KoResourcePaths: Fix review comments
- Use COMPILING_TESTS instead of NDEBUG
- Variable l -> location
- Improve api docs, fix typos
- Fix debug according to norm
danders marked 4 inline comments as done.
danders added inline comments.
INLINE COMMENTS
> staniek wrote in KoResourcePaths.cpp:47
> Isn't the modern like this?
>
> // in a header
> Q_DECLARE_LOGGING_CATEGORY(driverUsb)
>
> // in one source file
> Q_LOGGING_CATEGORY(driverUsb, "driver.usb")
Re
danders marked 4 inline comments as done.
danders added a comment.
Fixed some of your comments, I'll wait for more before updating.
INLINE COMMENTS
> staniek wrote in KoResourcePaths.cpp:43
> Can we drop the "ko" legacy here?
>
> Or even: do we really need a category per class/namespace or p
