Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-11 Thread Shou Ya
xi/widget/utils/kexidatetimeformatter.h 5d8e9fe kexi/widget/utils/kexidatetimeformatter.cpp fed7692 kexi/widget/utils/kexitooltip.h c0cf3b5 kexi/widget/utils/kexitooltip.cpp bd2e7c4 Diff: http://git.reviewboard.kde.org/r/107610/diff/ Testing --- T

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-10 Thread Shou Ya
b5 kexi/widget/utils/kexitooltip.cpp bd2e7c4 Diff: http://git.reviewboard.kde.org/r/107610/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-10 Thread Shou Ya
p.cpp bd2e7c4 Diff: http://git.reviewboard.kde.org/r/107610/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-09 Thread Shou Ya
/107610/diff/4/#index_header - Shou Ya On Dec. 9, 2012, 8:30 a.m., Shou Ya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-09 Thread Shou Ya
http://git.reviewboard.kde.org/r/107610/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-09 Thread Shou Ya
/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[GCI] I can't mark the issues as fixed on reviewboard

2012-12-07 Thread Shou Ya
Hi, I found it is not possible to mark them as fixed since the ajax seemed to return that I have no permission to do that. I don't know the reason. But anyway I'd fixed all the issues Artaud & Staniek mentioned. Please check it. Thank

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-07 Thread Shou Ya
et/fields/KexiFieldListModelItem.cpp fe55b12 kexi/widget/navigator/KexiProjectModelItem.h fe04381 kexi/widget/navigator/KexiProjectModelItem.cpp 764c17a kexi/widget/utils/kexidatetimeformatter.cpp fed7692 Diff: http://git.reviewboard.kde.org/r/107610/diff/ Testing --- Thanks,

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-06 Thread Shou Ya
.kde.org/r/107610/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-06 Thread Shou Ya
- Shou --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/#review23067 --- On Dec. 6, 2012, 1:52 p.m., Shou

Review Request: [GCI] Adding d-pointers (part #1)

2012-12-06 Thread Shou Ya
--- I've done with it for all the classes, please review. Good luck! Diffs - Diff: http://git.reviewboard.kde.org/r/107610/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/ma

Re: Review Request: add d-pointer for KexiScrollView

2012-12-05 Thread Shou Ya
lView who referred to some protected members of KexiScrollView. So I created some protected assessors for them. Diffs (updated) - kexi/plugins/forms/kexiformscrollview.cpp cad94c7 Diff: http://git.reviewboard.kde.org/r/107598/diff/ Testing --- Thanks

Re: Review Request: add d-pointer for KexiScrollView

2012-12-05 Thread Shou Ya
xi/plugins/forms/widgets/kexidbform.cpp c2dd1c5 kexi/widget/kexiscrollview.h 4fc6f85 kexi/widget/kexiscrollview.cpp 5a94228 Diff: http://git.reviewboard.kde.org/r/107598/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list call

Re: Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-05 Thread Shou Ya
`c', and generate a patch according that. Thanks. - Shou --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/#review22995 ------- On Dec. 4, 2012, 1:51 p.m., Shou Ya wrote: > > -

Re: Review Request: add d-pointer for KexiDBDriverComboBox

2012-12-05 Thread Shou Ya
d85fe4a Diff: http://git.reviewboard.kde.org/r/107588/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: add d-pointer for KexiScrollView

2012-12-05 Thread Shou Ya
.h c2e0eca kexi/plugins/forms/widgets/kexidbform.cpp c2dd1c5 kexi/widget/kexiscrollview.h 4fc6f85 kexi/widget/kexiscrollview.cpp 5a94228 Diff: http://git.reviewboard.kde.org/r/107598/diff/ Testing --- Thanks, Shou Ya ___ calligra-dev

Review Request: add d-pointer for KexiScrollView

2012-12-04 Thread Shou Ya
- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: add d-pointer for KexiProjectSelectorWidget

2012-12-04 Thread Shou Ya
rd.kde.org/r/107597/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Shou Ya
: http://git.reviewboard.kde.org/r/107579/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Shou Ya
/107579/diff/ Testing --- Thanks, Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-04 Thread Shou Ya
--- Just adding d-pointer for kexicharencodingcombobox. Diffs - kexi/widget/kexicharencodingcombobox.h 74fdfb2 kexi/widget/kexicharencodingcombobox.cpp 4be3315 Diff: http://git.reviewboard.kde.org/r/107578/diff/ Testing --- Thanks, Shou Ya

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Shou Ya
On Tue, Dec 4, 2012 at 6:46 PM, Sune Vuorela wrote: > On 2012-12-04, Shou Ya wrote: >>> OK, I am on IRC #kexi (freenode) mainly on the evenings CET; and >>> tomorrow most of the day. >> Unfortunately I can't use IRC, because the outgoing traffic of our >>

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Shou Ya
On Tue, Dec 4, 2012 at 4:50 PM, Jaroslaw Staniek wrote: > On 4 December 2012 07:39, Shou Ya wrote: >> Hi, >> >> I am working now on the task about adding d-pointers to Kexi, from >> Google >> Code-In(https://www.google-melange.com/gci/task/view/google/gci2012/79

[GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-03 Thread Shou Ya
x27;ll be able to contact instantly you when I meet a problem. Thanks. -- Shou Ya ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel