Re: Release

2021-12-14 Thread Pierre
On Monday, December 13, 2021 8:28:44 AM CET Dag wrote: > @pierre: > If I'm not mistaken you are planning a new release soon? > I cannot see that you have created a release branch, so presumely string- > and feature freeze are in effect? > Do you have a target date in mind? >

Re: Krita donation proposal

2021-11-16 Thread Pierre
ing one or two weeks ago. The information I had was that these were 'marked bills', usable only for Calligra and not for Krita. If we can share, let's share, sure. Regards Pierre signature.asc Description: This is a digitally signed message part.

Re: Words and large files

2021-04-04 Thread Pierre
On Monday, March 22, 2021 12:24:28 PM CEST Pierre wrote: > On Monday, March 22, 2021 9:01:21 AM CET Dag wrote: > > Hi, opened the odf spec in words the other day. > > This is a document with 800+ pages and a TOC of 60+ pages. > > I did the same in LO to compare. > > Do

Re: Words and large files

2021-03-23 Thread Pierre
On Monday, March 22, 2021 9:01:21 AM CET Dag wrote: > Hi, opened the odf spec in words the other day. > This is a document with 800+ pages and a TOC of 60+ pages. > I did the same in LO to compare. > Don't take the absolute times too seriously as my box is well into its > teenage years. > But, I th

Re: Words and large files

2021-03-22 Thread Pierre
So… firing up perf record and hotspot, with OpenDocument spec 1.2 (that's what I found in my homedir)… It takes about 21s to load, of which 34% is spent parsing the document (7s, still too much, but let's accept it so far) and 59% of the time is spent layouting. 14% of time is spent in KoTextR

Re: Words and large files

2021-03-22 Thread Pierre
ix them. And unlike the webbrowser comparison, we are not chasing a perpetually moving target with thousands of corporate developers adding features on their engines while being 0.1 unpaid developer on our engine… It's more like a few unpaid developers against less unpaid developers. Still not the best position for us, but far more manageable. Pierre signature.asc Description: This is a digitally signed message part.

Proposed release calendar

2021-03-21 Thread Pierre
x27;t take that much time so there will be some things to show… Is this ok for everybody? Regards Pierre signature.asc Description: This is a digitally signed message part.

Merge request in need of a review

2021-03-18 Thread Pierre
696-un-mois-de-travail-de-resurrection-d-un-projet-libre Regards Pierre signature.asc Description: This is a digitally signed message part.

Re: Clazy fixes and CI…

2021-02-22 Thread Pierre
On Saturday, February 13, 2021 2:43:46 PM CET Pierre wrote: > Hi > > In order to rejuvenate a bit some parts of the code base, I am looking into > Clazy, especially the old-style connect fixit. In several projects, > switching away from these made the application more reliab

Re: Clazy fixes and CI…

2021-02-13 Thread Pierre
On Saturday, February 13, 2021 3:24:35 PM CET Dan Leinir Turthra Jensen wrote: > Definitely support that effort as well, they are /much/ nicer to work with > just all 'round, and even if we can only depend on Qt 5.6, we /can/ depend > on a sufficiently modern compiler for our code to be less... anc

Clazy fixes and CI…

2021-02-13 Thread Pierre
could lower the entry barrier for new/junior developers… If somebody else already tried/did that, any feedback/hint/help is welcome obviously. Cheers Pierre signature.asc Description: This is a digitally signed message part.

Next release schedule/plans

2021-02-13 Thread Pierre
a review may be overkill… Regards Pierre signature.asc Description: This is a digitally signed message part.

Re: Code for msoscheme?

2021-02-11 Thread Pierre
On Thursday, February 11, 2021 9:45:01 PM CET you wrote: > On donderdag 11 februari 2021 21:40:19 CET Pierre wrote: > > Hello > > Hi Pierre! > > > I am looking at several warnings in the code generated by msoscheme in the > > libmso filters. The fix should be ea

Code for msoscheme?

2021-02-11 Thread Pierre
lost? Regards Pierre signature.asc Description: This is a digitally signed message part.

Re: Minimum dependency versions

2021-02-11 Thread Pierre
On Wednesday, February 10, 2021 8:39:35 PM CET Carl Schwan wrote: > Le mercredi, février 10, 2021 7:45 PM, Pierre a écrit : > > On Wednesday, February 10, 2021 9:30:43 AM CET Adam Pigg wrote: > > > I wish!!! ... try qt 5.6! > > > > > > On Wed, 10 Feb 2021 at

Re: Minimum dependency versions

2021-02-10 Thread Pierre
On Wednesday, February 10, 2021 8:45:23 PM CET Camilla Boemann wrote: > I agree let's move ahead. We can't be defined by what Jolla does and needs > > However let's only do it if development is going to pick up. No need to > annoy Jolla and then for everything to stall. Well if everything stalls,

Re: Minimum dependency versions

2021-02-10 Thread Pierre
On Wednesday, February 10, 2021 9:30:43 AM CET Adam Pigg wrote: > I wish!!! ... try qt 5.6! > > On Wed, 10 Feb 2021 at 08:14, Halla Rempt wrote: > > On Wednesday, 10 February 2021 08:44:54 CET Pierre wrote: > > > Is there a lot of people still trying to build Calligra

Re: Minimum dependency versions

2021-02-10 Thread Pierre
On Wednesday, February 10, 2021 9:13:49 AM CET Halla Rempt wrote: > On Wednesday, 10 February 2021 08:44:54 CET Pierre wrote: > > Is there a lot of people still trying to build Calligra with Qt 5.3 or KF5 > > 5.7.0 ? These are years old, and I guess building Calligra with th

Minimum dependency versions

2021-02-09 Thread Pierre
guess building Calligra with them has been untested for some time. May I suggest updating to Qt 5.12 / KF5 5.60 ? This would be a first step, and will make it easier to fix deprecation warnings in a way that should work with all supported Qt and KF5 versions. Regards Pierre Ducroquet signatur

Congratulations on the handshake founding

2018-10-15 Thread Pierre
just want to chat, I'm often on freenode (nick Pinaraf). Wish you the best Pierre signature.asc Description: This is a digitally signed message part.

Re: Static code analysis - the easiest way to improve

2016-03-15 Thread Pierre
On Tuesday, March 15, 2016 05:45:44 PM Jaroslaw Staniek wrote: > On 15 March 2016 at 17:33, Tomas Mecir wrote: > > No change for me, unfortunately, still getting that red box (tried > > both password and github login). > > ​I see. All I did is asking scan-ad...@coverity.com 2 times or so. > And w

Re: Coverity scan results

2016-02-20 Thread Pierre
On Friday, February 19, 2016 02:05:04 AM Nick Shaforostoff wrote: > > https://scan.coverity.com/projects/kde/view_defects and I then get the > > message «Failed to view defects: It may take a few minutes before you can > > view your defects for the first time or when you change your email.» > > wh

Re: Coverity scan results

2016-02-18 Thread Pierre
our defects for the first time or when you change your email.» Do you have any idea why this happens ? Pierre signature.asc Description: This is a digitally signed message part. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: Resetting metadata after new from template ?

2016-02-06 Thread Pierre
On Thursday, February 04, 2016 01:55:19 PM Friedrich W. H. Kossebau wrote: > Hi Pierre, > > Am Dienstag, 2. Februar 2016, 22:21:59 schrieb Pierre: > > On Tuesday, February 02, 2016 02:08:53 PM Jaroslaw Staniek wrote: > > > On 1 February 2016 at 23:20, P

Re: Resetting metadata after new from template ?

2016-02-02 Thread Pierre
On Tuesday, February 02, 2016 02:08:53 PM Jaroslaw Staniek wrote: > On 1 February 2016 at 23:20, Pierre wrote: > > Hi > > > > Right now, when we create a new empty document (at least for words), like > > any > > other office suite, it is created from a templa

Resetting metadata after new from template ?

2016-02-01 Thread Pierre
ut elsewhere in the saving code) Any thoughts on this ? Thanks Pierre signature.asc Description: This is a digitally signed message part. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: I'm back

2015-01-13 Thread Pierre
On Tuesday, January 13, 2015 12:41:06 PM Inge Wallin wrote: > Hi everybody, > > Some of you know already that I have been very sick but perhaps not everybody. > However, I am much better now and recovery has gone so far that I feel that I > can come back into the KDE and Calligra families again an

Re: calligra 2.9 Beta 1 changelog

2014-12-09 Thread Pierre
e pages layouts. So far it has no real user visible improvements (except old bugs replaced by new bugs) but that change had to be done first. I hope to have new features before the final release. Pierre signature.asc Description: This is a digit

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-12-07 Thread Pierre
On Saturday, December 06, 2014 07:11:04 PM Dan Leinir Turthra Jensen wrote: > This is, i know, somewhat late in the review phase, but i expect it's a > smallish issue anyway. In short, 4fa0b6e29d31d7755441b231ea3bf2ef068435b4 > breaks text input in Stage. Which i discovered while setting out to mak

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Pierre Ducroquet
behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Pierre Ducroquet
background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-26 Thread Pierre Ducroquet
d up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-19 Thread Pierre Ducroquet
https://git.reviewboard.kde.org/r/120733/diff/ Testing --- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ call

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-08 Thread Pierre Ducroquet
behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-07 Thread Pierre Ducroquet
r.cpp ce039219c1a044b13ae81420832eb894346b88db Diff: https://git.reviewboard.kde.org/r/120733/diff/ Testing --- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre

Re: 2.9 and 2.8.7

2014-11-07 Thread Pierre
On Friday, November 07, 2014 11:57:45 PM Jaroslaw Staniek wrote: > That said, if we had to release 2.9 on time we would need beta soon. > So if 2.9 is delayed, 2.8.7 makes sense. Today I backported 6 fixes > from Kexi master to 2.8. > > I see Krita and others have no backported stuff. Is it planne

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-01 Thread Pierre Ducroquet
ou have run cs tester on > > this, and otherwise tested it I've run some more tests and found an issue (likely a stop condition I lost in the merge of the KoTextDocumentLayout function), I'll not merge until it's fixed of course, and depending on the patch siz

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-28 Thread Pierre Ducroquet
-- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.o

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-24 Thread Pierre Ducroquet
ding the > > need to release all after) if it mismatches the next available page in the > > current list of pages > > > > possibly this could be even smarter > > Pierre Ducroquet wrote: > I partially agree, I'll try that way nevertheless, but

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-23 Thread Pierre Ducroquet
iff/1/?file=321682#file321682line757> > > > > this part i don't like being in the library - i think it should rest > > upon the provider I agree, I don't like it either. I just didn't want to alter the rootAreaProvider interface too much, but I'll

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-23 Thread Pierre Ducroquet
nt) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-22 Thread Pierre Ducroquet
ument with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailma

Words - how to add a way for users to change page styles ?

2014-10-19 Thread Pierre
7;t share the hack code right now, it's broken and beyond redemption :) Thanks Pierre signature.asc Description: This is a digitally signed message part. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

2014-10-18 Thread Pierre Ducroquet
PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

2014-10-18 Thread Pierre Ducroquet
/ Testing --- Check with the file of bug report 337675 : no more crash. Check with cstester and ~50 .doc files : the changes are always closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing

Re: Review Request 120645: Msword filter - Fix the page top border when there is a header

2014-10-18 Thread Pierre Ducroquet
closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 120645: Fix the page top border when there is a header

2014-10-18 Thread Pierre Ducroquet
://git.reviewboard.kde.org/r/120645/diff/ Testing --- Check with the file of bug report 337675 : no more crash. Check with cstester and ~50 .doc files : the changes are always closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-03 Thread Pierre Ducroquet
out/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-02 Thread Pierre Ducroquet
out/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-02 Thread Pierre Ducroquet
ere. Diffs - libs/textlayout/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pie

Re: Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
ibs/textlayout/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calli

Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: How to get all characters on a page in Words and their position

2014-09-29 Thread Pierre
ch you can then dynamically cast to TextShape objects, whose textShapeData contain a QTextDocument object. That should get you the text of a given page, as far as I remember. Regarding distance calculation, I don't really understand what you want to do. Do you want to be able to get, for an

Re: Review Request 120375: Don't look further than what we are currently layouting

2014-09-26 Thread Pierre Ducroquet
sting done on : - the two test cases for bug 332220 : no more crash, comment still visible. - a simple non-crashing file : no crash, comment still visible. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kd

Review Request 120375: Don't look further than what we are currently layouting

2014-09-25 Thread Pierre Ducroquet
imple non-crashing file : no crash, comment still visible. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2.8.6 Changelog -- Reminder

2014-09-22 Thread Pierre
On Monday, September 22, 2014 09:46:44 PM Jaroslaw Staniek wrote: > Thanks, already added all items since 2.8.5. The one you mentioned is > added to a General section (since it's in the text layout lib) and > called: > > Prevent backtracking to undo the layout of a whole page, thus starting > an i

Re: 2.8.6 Changelog -- Reminder

2014-09-22 Thread Pierre
On Tuesday, September 16, 2014 09:47:17 PM Jaroslaw Staniek wrote: > Hi everybody, > 2.8.6 release is appraching [1], it's time to collect changelog items. > I see a number of commits outside of kexi/ and krita/ .. any takers? > Earlier is better. Hi I think you can add a fix of a few crashes for

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre
On Thursday, September 18, 2014 07:48:41 PM Camilla Boemann wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120250/#review66864 > --

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
> On Sept. 18, 2014, 7:06 p.m., Camilla Boemann wrote: > > as far as I see it this code will always backtrack one block too much - can > > you please check > > > > But it correctly doesn't back track at all if all blocks have keep with next Thanks, the new dif

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
eport 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
report 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
s (updated) - libs/textlayout/KoTextLayoutArea.cpp c74dbd4 Diff: https://git.reviewboard.kde.org/r/120250/diff/ Testing --- Checked with the document from bug report 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre

Re: Review Request 120250: Change blockLayout return to be more explicit

2014-09-17 Thread Pierre
On Wednesday, September 17, 2014 10:16:35 PM Pierre wrote: > On Wednesday, September 17, 2014 08:09:24 PM Pierre Ducroquet wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > https://git.

Re: Review Request 120250: Change blockLayout return to be more explicit

2014-09-17 Thread Pierre
On Wednesday, September 17, 2014 08:09:24 PM Pierre Ducroquet wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org

Review Request 120250: Change blockLayout return to be more explicit

2014-09-17 Thread Pierre Ducroquet
. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Anatomy of the style manager

2013-05-30 Thread Pierre Stirnweiss
nusedParagraphStyles, along with the associated > API addUnusedStyle(...) and moveToUsedStyles(...) was added later by > Gopalakrishna. > > The last two are the most recently added, by Pierre, for use in the > DockerStylesComboModel. > > Taking a paragraph style as example, when it is added t

Re: Review Request 109651: Refactor style manager

2013-03-26 Thread Pierre Stirnweiss
environment and restore my repo from the backup. I'll try to do that during the week. See you soon, Pierre On Mon, Mar 25, 2013 at 11:22 AM, C. Boemann wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109651/ > > Ship it!

Re: next release and release pace in general

2013-01-26 Thread Pierre Stirnweiss
of a testing branch is however how do we ensure that it gets sufficient testing. Pierre ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: next release and release pace in general

2013-01-24 Thread Pierre Stirnweiss
ill be able to deliver > - new interactive anchor ui > - insertion of hyperlinks > - restoring the review tool (without changetracking but with ui for > spellchecking, tagging text with language) > - new modebox (the sidebar thing) [done] > - new zoom mode in Words [done] >

Review Request 108532: Fix crash in krita master on style combo

2013-01-21 Thread Pierre Stirnweiss
plugins/textshape/dialogs/DockerStylesComboModel.cpp 472f8b4 plugins/textshape/dialogs/StylesModel.cpp a264855 Diff: http://git.reviewboard.kde.org/r/108532/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request 108444: Fix cash on creating new character style

2013-01-18 Thread Pierre Stirnweiss
plugins/textshape/dialogs/StylesModel.cpp 80ea48d Diff: http://git.reviewboard.kde.org/r/108444/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108444: Fix cash on creating new character style

2013-01-17 Thread Pierre Stirnweiss
not apply cleanly for me > against 2.6 at least. > > > - Friedrich W. H. > > On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote: > Review request for Calligra and Friedrich W. H. Kossebau. > By Pierre Stirnweiss. > > *Updated Jan. 16, 2013, 8:45 p.m.*

Review Request 108444: Fix cash on creating new character style

2013-01-16 Thread Pierre Stirnweiss
--- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108379: Fix merging style to caret

2013-01-13 Thread Pierre Stirnweiss
a style to the caret was not effective when the caret had no selection. This change correct that bug. Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 5a35fe8 Diff: http://git.reviewboard.kde.org/r/108379/diff/ Testing --- Thanks, Pierre Stirnweiss

Review Request: Fix crash on empty style list in StyleManager dialog

2013-01-11 Thread Pierre Stirnweiss
--- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix wrong style applied when backspace

2013-01-05 Thread Pierre Stirnweiss
://git.reviewboard.kde.org/r/108199/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix applying style to a caret without a selection

2013-01-04 Thread Pierre Stirnweiss
and eventually the character style (if we set one). Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 7bd345b Diff: http://git.reviewboard.kde.org/r/108191/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-dev

Review Request: Fix applying style to a caret without a selection

2013-01-04 Thread Pierre Stirnweiss
(if we set one). Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 7bd345b Diff: http://git.reviewboard.kde.org/r/108191/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-deve

Review Request: Merge textshape-stylesWidget-PierreSt in master

2013-01-01 Thread Pierre Stirnweiss
/ Testing --- Played around with the combo. Also fixed some issues spotted by Boemann earlier. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Remove the default paragraph style from user visible lists

2012-12-31 Thread Pierre Stirnweiss
ext/styles/KoStyleManager.cpp 480fa19 plugins/textshape/dialogs/StylesModel.cpp 0e33084 Diff: http://git.reviewboard.kde.org/r/108051/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://ma

Re: Review Request: spellchecking changes

2012-12-31 Thread Pierre Stirnweiss
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108022/#review24325 --- Ship it! Ship It! - Pierre Stirnweiss On Dec. 31, 2012, 12

Review Request: Fix sorting of style names

2012-12-30 Thread Pierre Stirnweiss
natural order now. I could not test regressions where locale comparison would play a role however. But since KStringHandler's comparison uses the Qt one, I don't expect a regression there. Thanks, Pierre Stirnweiss ___ calligra-devel mailing lis

Review Request: Fix apply characterStyle to a caret without selection

2012-12-23 Thread Pierre Stirnweiss
cursor does not have a selection, the character style was not applied. Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp d1f0694 Diff: http://git.reviewboard.kde.org/r/107878/diff/ Testing --- Thanks, Pierre Stirnweiss

Review Request: Fix clicking in selection does not update caret

2012-12-22 Thread Pierre Stirnweiss
http://git.reviewboard.kde.org/r/107849/diff/ Testing --- Now it works for me ;) Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
tinfo/calligra-devel > basicflakes then? However, I think we are putting the cart before the horses there. Shouldn't we first agree on a structure before discussing labels? Pierre ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
nt. I personally think this should go into a lib. I would not advocate merging it with kotext however, because kotext is (AFAICT) and should stay non GUI. Then there is a part of it which is GUI stuff (even within TextTool.cpp), this is UI/form factor dependent. I think it should be somehow organi

Review Request: Fix applying paragraphStyle

2012-12-06 Thread Pierre Stirnweiss
Diff: http://git.reviewboard.kde.org/r/107616/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix next style appears as modified after new line on header style (bug 293378).

2012-12-01 Thread Pierre Stirnweiss
to work, and I have not spotted regressions. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Make it possible to override info from author profile via dbus/c++

2012-11-28 Thread Pierre Stirnweiss
<http://git.reviewboard.kde.org/r/107486/#comment17365> What is the difference between ActiveAuthorInfo and AuthorInfo? Perhaps a tad more verbose description. - Pierre Stirnweiss On Nov. 27, 2012, 12:14 p.m., C. Boemann

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
--- Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
board.kde.org/r/107445/diff/2/?file=96362#file96362line65> > > > > really? Yes, we use the delegate's clickedInItem signal. I had a double emission. I have not removed the lines completely for safety reasons. - Pierre -

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-26 Thread Pierre Stirnweiss
--- Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-26 Thread Pierre Stirnweiss
eally can't remember what it was for. It has I think nothing to do with the present functionality, so I'll remove this. - Pierre --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445

Review Request: Sort styles according to usage in the docker's combos

2012-11-24 Thread Pierre Stirnweiss
glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Introduce KoTextRange instead of inline characters

2012-10-25 Thread Pierre Stirnweiss
On Thu, Oct 25, 2012 at 9:39 AM, Inge Wallin wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106983/ > > Ship it! > > Looks good now. > > Only thing was that copyright notice is still missing in some files and some > files still have cod

Re: Distraction free writing mode

2012-09-10 Thread Pierre Stirnweiss
the maintenance burden. However I am not sure it really would be that much, I think these classes are now really mature and won't change that much. However, since I personally don't have the time to do all this, the decision is not mine. Pierre ___

Re: Distraction free writing mode

2012-09-07 Thread Pierre Stirnweiss
Time to involve the whole devel list I think: Here is roughly where we stand in a discussion (between Inge and me, with some public) about distraction free mode. I think it is becoming concrete enough and will be of interest for others in the ML. Pierre On Fri, Sep 7, 2012 at 10:16 AM, Inge

  1   2   3   >