D24852: Remove list style from headings

akomakhin updated this revision to Diff 69568. akomakhin added a comment. OK, let's set formatSpecification explicitly to Empty if "num-format" value is empty. OASIS 1.2 says, in cases "an empty string" or "no value" is given, then no number sequence is displayed. REPOSITORY R8 Calligra C

D24852: Remove list style from headings

akomakhin added a comment. According to this is it correct to set formatSpecification to Empty if "num-format" value is empty in all lists, not only in headings? REPOSITORY R8 Calli

D24852: Remove list style from headings

akomakhin added a comment. But there is a simple statement in loadOdf function: if "num-format" is empty, then formatSpecification has a default value -- Numeric style. Isn't it strange, assuming all list styles numerical? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.o

D24852: Remove list style from headings

akomakhin updated this revision to Diff 69451. akomakhin edited the summary of this revision. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24852?vs=68509&id=69451 REVISION DETAIL https://phabricator.kde.org/D24852 AFFECTED FILES libs/odf/KoOdfNumberDefin

D24852: Remove list style from headings

akomakhin added a comment. In D24852#553906 , @boemann wrote: > All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case Interesting: saving document with numbered, and

D24852: Remove list style from headings

akomakhin added a comment. In D24852#552012 , @boemann wrote: > I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases list->add(block, level); is called ever

D24852: Remove list style from headings

akomakhin edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

akomakhin created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. akomakhin requested review of this revision. REVISION SUMMARY F7645960: Снимок_Экрана_20191001_001.png Bug description: headings ar

D24852: Remove list style from headings

akomakhin added reviewers: pvuorela, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24830: Add support for strikeout text in RTF documents

akomakhin marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D24830 To: akomakhin, pvuorela, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24830: Add support for strikeout text in RTF documents

akomakhin updated this revision to Diff 68442. akomakhin added a comment. Fixed set value from "true" to expression " ! hasValue || ( hasValue && value != 0 ) " CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24830?vs=68436&id=68442 REVISION DETAIL https://phabricator.kde.org/D248

D24830: Add support for strikeout text in RTF documents

akomakhin created this revision. akomakhin added reviewers: pvuorela, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. akomakhin requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24830 A