D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-01 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KoDialog.cpp:161 > > -QObject::connect(button, SIGNAL(clicked()), > - &mButtonSignalMapper, SLOT(map())); > +QObject::connect(but

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-01 Thread Carl Schwan
ognarb retitled this revision from "[WIP]: Port away from QSignalMapper" to "[WIP]: Port away from deprecated QSignalMapper". ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6 Cc: Calligra-D

D25664: [WIP]: Port away from QSignalMapper

2019-12-01 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb edited the test plan for this revision. ognarb added reviewers: Calligra: 3.0, KF6. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6 Cc: Calligra-Devel-list, davidllewellynjones, dcal

D25664: [WIP]: Port away from QSignalMapper

2019-12-01 Thread Carl Schwan
ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REPOSITORY R8 Calligra BRANCH port-away-signalmapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D25664 AFF

D25560: refactor: Run clang-tity modernize override

2019-12-01 Thread Carl Schwan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:e82b7dde192b: refactor: Run clang-tity modernize override (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE