D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Camilla Boemann
boemann added a comment. To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow. So I'm okay with it REPOSITORY R8 Calligra REVISION DETAIL https:

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Anthony Fieroni
anthonyfieroni added a reviewer: Calligra: 3.0. anthonyfieroni added a comment. Let's other members leave their opinion as well. I don't want to have surprised people by removing Flow. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni,

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders added a comment. Yeah, well. If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it. As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very si

D25256: Allow non-conforming LibreOffice PPT files to be imported

2019-11-11 Thread David Llewellyn-Jones
davidllewellynjones added a comment. Here's the corresponding patch for binschema: https://github.com/KDE/binschema/pull/1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25256 To: davidllewellynjones, pvuorela, dcaliste Cc: Calligra-Devel-list, davidllewellynjones,

D25256: Allow non-conforming LibreOffice PPT files to be imported

2019-11-11 Thread David Llewellyn-Jones
davidllewellynjones created this revision. davidllewellynjones added reviewers: pvuorela, dcaliste. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY An apparent bug in the L

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm unsure about that, if some people still prefer using Flow will make this change superfluous. I can't make decision about this changes, if you think it should be done - i'm fine. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since karbon is multipage app and stencils docker can be used by all apps,

D24852: Remove list style from headings

2019-11-11 Thread Anthony Fieroni
anthonyfieroni added a comment. +1, i'm ok with that. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25033: Extract images from excel files which omit the FtCF entry.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:b253bef8dc85: Extract images from excel files which omit the FtCF entry. (authored by denexter, committed by pvuorela). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25033?vs=68943&id=69569#toc

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:66ea04a230d7: Read xlsx drawing dimensions from the xdr:ext element if available. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.

D25035: Fix incorrect conditional styling of spreadsheet cells.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:345f970a6deb: Fix incorrect conditional styling of spreadsheet cells. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D250

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:cec1e93bb7d5: Don't allow an unrecognized child element to block loading of a shape plugin. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://p

D25036: Don't double format spreadsheet currency values with custom format strings.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:44e297458950: Don't double format spreadsheet currency values with custom format strings. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://pha

D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol.

2019-11-11 Thread Pekka Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R8:d0b2c2f9afdf: Don't drop number styling information from xlsx cell formats which start with a… (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https:

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

2019-11-11 Thread Pekka Vuorela
pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25032 To: denexter, pvuorela Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

2019-11-11 Thread Aleksandr Komakhin
akomakhin updated this revision to Diff 69568. akomakhin added a comment. OK, let's set formatSpecification explicitly to Empty if "num-format" value is empty. OASIS 1.2 says, in cases "an empty string" or "no value" is given, then no number sequence is displayed. REPOSITORY R8 Calligra C

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69566&id=69567 REVISION DETAIL

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
danders updated this revision to Diff 69566. danders added a comment. Remove unused include REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69438&id=69566 BRANCH multipage_image_danders REVISION DETAIL https://phabricator.kde.org/D25214 AFFECT

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

2019-11-11 Thread Pekka Vuorela
pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25031 To: denexter, pvuorela Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

2019-11-11 Thread Aleksandr Komakhin
akomakhin added a comment. According to this is it correct to set formatSpecification to Empty if "num-format" value is empty in all lists, not only in headings? REPOSITORY R8 Calli