D23617: [gemini] Remove "template://" scheme from file name

2019-09-02 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Something tells me there's going to be problems on windows if this gets done... since that is the precise reason that code exists in the first place: https://phabricator.kde.org/R

D23617: [gemini] Remove "template://" scheme from file name

2019-09-02 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 65255. anthonyfieroni added a comment. Test plan: 1. Open existing document -> works 2. Open template document -> works 3. Create new document -> works REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23617

D23492: Correct anchor detection in QML components.

2019-09-02 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:f0f0eedf1e74: Correct anchor detection in QML components. (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23492?vs=65201&id=65245 REVISION DETA

D23679: Correct anchor detection in QML components.

2019-09-02 Thread Damien Caliste
dcaliste abandoned this revision. dcaliste added a comment. Sorry, made a mistake with arc… This differential revision is already D23492 . REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23679 To: dcaliste Cc: Calligra-Devel-list,

D23679: Correct anchor detection in QML components.

2019-09-02 Thread Damien Caliste
dcaliste created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REPOSITORY R8 Calligra BRANCH anchors REVISION DETAIL https://phabricator.kde.org/D23679 AFFECTED FILES components/impl/Pres

D23492: Correct anchor detection in QML components.

2019-09-02 Thread Pekka Vuorela
pvuorela added a comment. And even rendering now better, no idea what happened. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23492 To: dcaliste, leinir, pvuorela, danders, boemann Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever

D23492: Correct anchor detection in QML components.

2019-09-02 Thread Pekka Vuorela
pvuorela accepted this revision. pvuorela added a comment. Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the raw diff looks good now. Trust all good :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23492 To: dcaliste, leinir, pvuorela, d

D23617: [gemini] Remove "template://" scheme from file name

2019-09-02 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D23617#523417 , @anthonyfieroni wrote: > That makes sense but none handle that schemes or should be responsible for that? It's handled by the components: https://phabricator.kde.org/source/calligra/browse/mast

D23492: Correct anchor detection in QML components.

2019-09-02 Thread Damien Caliste
dcaliste updated this revision to Diff 65201. dcaliste added a comment. Thank you pvuorela pointing out other places for this construct. I've updated the patch with a fix for the faulty loops for spreadsheets and presentations also. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https