D19943: Small cleanups for qml components

2019-03-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pvuorela wrote in Document.cpp:221 > Nothing, but that's how it used to be. The intention might have been > different, but effectively it's two disconnects without actu

D19943: Small cleanups for qml components

2019-03-27 Thread Pekka Vuorela
pvuorela added inline comments. INLINE COMMENTS > leinir wrote in Document.cpp:221 > What happens to this signal now? Nothing, but that's how it used to be. The intention might have been different, but effectively it's two disconnects without actual connection appearing anywhere as far as I ca

D19944: Migrate away from deprecated interfaces in gemini dropbox parts

2019-03-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff

D19943: Small cleanups for qml components

2019-03-27 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > Document.cpp:221 > -if (d->textEditor) { > -disconnect(d->textEditor, SIGNAL(cursorPositionChanged()), this, > SIGNAL(selectionChanged())); > -} What happens to this signal now? REPOSITORY R8 Calligra REVISION DETAI