D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-19 Thread Damien Caliste
dcaliste added inline comments. INLINE COMMENTS > TextDocumentStructureModel.cpp:308 > > -reset(); > } I did the same changes in https://phabricator.kde.org/D15102 at another place and I put the begin and end at the start and end of the routine, like you did. But I remember that I got r

D19885: Implement logging category for excel plugins

2019-03-19 Thread Pekka Vuorela
pvuorela updated this revision to Diff 54337. pvuorela added a comment. Eliminated one unintended #ifdef SWINDER_XLS2RAW removal from the patch. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19885?vs=54323&id=54337 REVISION DETAIL https://phabricator.kde

D19885: Implement logging category for excel plugins

2019-03-19 Thread Pekka Vuorela
pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Previous std::cout/printf as debug output, std::cerr/stderr as warning output. Not 100% the same output, but shou

D19759: Remove unsupported attributes from QGraphicsWidgets

2019-03-19 Thread Pekka Vuorela
pvuorela updated this revision to Diff 54325. pvuorela retitled this revision from "Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets" to "Remove unsupported attributes from QGraphicsWidgets". pvuorela edited the summary of this revision. pvuorela added a comment. Updated to re

D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-19 Thread Pekka Vuorela
pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19884 AFFECTED FILES plugins/textshape/TextDocumentStructur