D19327: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. Ported to use pageapp classes. K

D15428: [textlayout] Don't enter infinite loop when table is misfit

2019-02-25 Thread Camilla Boemann
boemann added a comment. no REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

2019-02-25 Thread Dag Andersen
danders added a comment. Can we get a conclussion to this? @Camilla Have you come up with any more unit tests? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vand

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: danders, anthonyfieroni Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Camilla Boemann
boemann added a comment. totally agree about not theme'ing canvas Also a general agreement to do the page app thing as long as it's also supported in svg odg is hardly that much of a reason - it even seems like odf is moving away from odg as much as possible REPOSITORY R8 Calligr

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > We can remove "number of recent files" since other apps does not have it. but > for other 2 i don't see why we remove them, someone can found useful > (somehow). About me, i want them

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders added a comment. In D19216#417502 , @rjvbb wrote: > > Canvas color: > > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. > > A custom canvas colour feat