D19132: Update libs/widgets to c++11

2019-02-22 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R8:c32f7ef9bbbf: Update libs/widgets to c++11 (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52121&id=52341 REVISION DETAIL https://phab

D19216: Karbon: Enable multi page capability

2019-02-22 Thread René J . V . Bertin
rjvbb added a comment. > Canvas color: > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a de

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KarbonDocument.h:100-109 > +// TODO: Start using or remove > /// Returns the documents data centers > QMap dataCenterMap() const; > > +// TODO: Start using or remove > /// Sets the data centers to be used by this doc

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > I want to discuss comments in the review, i don't want to have in. why we > remove this? Recent file & docker font: Why does karbon need these, none of the other apps have it. Personal

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > KarbonConfigInterfacePage.cpp:73-90 > +// TODO or move or remove? > +// m_recentFiles = new QSpinBox(tmpQGroupBox); > +// m_recentFiles->setRange(1, 20); > +// m_recentFiles->setSingleStep(1); > +// m_recentFiles->setValue(m_

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders added a comment. In D19216#417288 , @rjvbb wrote: > This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would jus

Re: D19216: Karbon: Enable multi page capability

2019-02-22 Thread René J . V . Bertin
This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone). You should also test with PDF documents; in my experience Karbo

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support