D18095: Add new table layout unit tests

2019-01-08 Thread Dag Andersen
danders added a comment. No, all do not pass, generally when the first row is merged, layout fails. (I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428 .) REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18095: Add new table layout unit tests

2019-01-08 Thread Camilla Boemann
boemann added a comment. Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed I'll think about further tests REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Callig

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jaroslaw Staniek
Ok, thanks! https://phabricator.kde.org/D18096 On Tue, 8 Jan 2019 at 13:32, Jonathan Riddell wrote: > Yes, that's how Plasma and Applications do it. Not all projects to it > this way, but once a new stable branch is made repo-metadata's stable > branch should be updated to allow translations. >

D18095: Add new table layout unit tests

2019-01-08 Thread Dag Andersen
danders added a comment. Not trivial (for me) to get data out of layout so it is hard to create robust tests. I don't think I have been able to create a test to simulate the loop excactly. Also, uncertain wether the MockRootAreaProvider is sufficient. Any ideas/comments wellcome. REPOSI

D18095: Add new table layout unit tests

2019-01-08 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds multiple areas capabilities and tests with merged cells REPOSI

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jonathan Riddell
Yes, that's how Plasma and Applications do it. Not all projects to it this way, but once a new stable branch is made repo-metadata's stable branch should be updated to allow translations. Jonathan On Tue, 8 Jan 2019 at 12:28, Jaroslaw Staniek wrote: > > > > On Tue, 8 Jan 2019 at 13:22, Jonathan

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jaroslaw Staniek
On Tue, 8 Jan 2019 at 13:22, Jonathan Riddell wrote: > It blocks any translations to 3.2 branch as there's nowhere the > translations end up. > > In KDE neon we also set our dev-stable builds using the repo-metadata > branches so I'd need to override those to build this forthcoming > release as w

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jonathan Riddell
It blocks any translations to 3.2 branch as there's nowhere the translations end up. In KDE neon we also set our dev-stable builds using the repo-metadata branches so I'd need to override those to build this forthcoming release as we do for other beta and pre-beta software. Jonathan On Tue, 8 Ja

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jaroslaw Staniek
Does it block anything on your end? If so we can update. CI already has stable set to 3.2 for example. 3.1 branch is for the current stable because nothing from 3.2 is released. We have 3.2 earlier because we had to bump minor version due to new APIs. On Tue, 8 Jan 2019 at 12:44, Jonathan Riddell

Re: KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jonathan Riddell
The stable branch is still set to 3.1 in repo-metadata Jonathan On Tue, 8 Jan 2019 at 09:59, Jaroslaw Staniek wrote: > > > Dear All, > I'd like to declare string freeze for 4 projects: KEXI, KDb, > KProperty, KReport version 3.2.0. > > Beta would be announced on Jan 21st. > Stable is planned for

KEXI, KDb, KProperty, KReport 3.2.0 ready to translate

2019-01-08 Thread Jaroslaw Staniek
Dear All, I'd like to declare string freeze for 4 projects: KEXI, KDb, KProperty, KReport version 3.2.0. Beta would be announced on Jan 21st. Stable is planned for February so there is one month for testing messages and translating. There are not too many new strings. Translating of docs is not re