D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. And has anyone been able to produce a smaller 1 page example of the document - we are stumbling blindly here. Do we have an odf snippet of the table that gives the problem? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyf

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. Still not the description i was looking for. I want to know what the extreme case is and what the resulting document should look like when we give up: A table without header rows and that doesn't fit will be layouted and shown in pieces What I want to know

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. In facts that's 2 crashes, first one in ascent, second one misfit. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378432 , @boemann wrote: > No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words Ahhh. It's a guard against loop/crash in extreme

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Call

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. @danders you can commandeer this revision to update diff. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378422 , @boemann wrote: > Dan I like your diff better - I don't think it's completely there but it's a better starting point > > On a more conceptual level, what should happen if the design of table is suc

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378420 , @anthonyfieroni wrote: > Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases? Mine tries to take into account the case where the first row after header

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. Dan I like your diff better - I don't think it's completely there but it's a better starting point On a more conceptual level, what should happen if the design of table is such that headers can't fit on a virgin page? What should we do.? One one hand it should b

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste,

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. I ended up in the same spot as you: Since all columns in row 0 spans rows, totalMisFit will always be set to true and the whole table is layed out on next page, and next page again and again ... I'm not 100% certain just adding noCellsFitted to the condition cov