D16721: Use Krita toolbar in Karbon

2018-11-10 Thread Ben Cooksley
bcooksley added a comment. Anyone who has already pulled in the latest changes will need to forcibly reset their local working tree after the force push is completed. Should they have staged work, this would need to be rebased, which can be a non-trivial process and one many developers will

D16721: Use Krita toolbar in Karbon

2018-11-10 Thread Anthony Fieroni
anthonyfieroni added a comment. In D16721#356863 , @bcooksley wrote: > Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? I really prefer to not have

D16784: Remove whitespace created by D16721

2018-11-10 Thread Anthony Fieroni
anthonyfieroni added a comment. But it's not only that https://phabricator.kde.org/R8:a7ee6f871af225fd5edc9458ee183604fabadc8a Notice ~SectionLayout() and many others, you should use settings that trim whitespaces on file save. In Kate -> settings -> open/save -> Remove trailing spaces ->