D16784: Remove whitespace created by D16721

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16784 To: ognarb, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16784: Remove whitespace created by D16721

ognarb created this revision. ognarb added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY :( REPOSITORY R8 Calligra BRANCH master REVISION DETAIL https://phabri

D16721: Use Krita toolbar in Karbon

bcooksley added a comment. Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, anthonyfieroni Cc: b

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a subscriber: bcooksley. anthonyfieroni added a comment. Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them. > That do you recommend as a

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356813 , @anthonyfieroni wrote: > Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write he

D16721: Use Krita toolbar in Karbon

This revision was automatically updated to reflect the committed changes. Closed by commit R8:a7ee6f871af2: Use Krita toolbar in Karbon (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45181&id=45182 REVISION DETAIL https://phabr

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45181. ognarb marked an inline comment as done. ognarb added a comment. Remove all whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45173&id=45181 BRANCH master REVISION DETAIL https://phabricator.

D16721: Use Krita toolbar in Karbon

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write

D16721: Use Krita toolbar in Karbon

ognarb removed a reviewer: Krita. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, #krita Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356755 , @anthonyfieroni wrote: > Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45173. ognarb marked 5 inline comments as done. ognarb added a comment. Fix REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45169&id=45173 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AF

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :) INLINE COMMENTS > ognarb wrote in KoToolBoxDoc

Re: Plan freeze

Dag skrev den 2018-10-29 14:29: I'm working on moving plan into separate repository to ease release work. Please do not do any work on plan until futher notice. Done, named calligraplan, so open for contributions :)

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356595 , @anthonyfieroni wrote: > Can you test my suggestions, it's looks good to me. Yes work also for me :) About the title bar for the dock, I'm not a fan of KoDockWidgetTitleBar for the tool bar

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45169. ognarb marked 9 inline comments as done. ognarb added a comment. Apply change according to review REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45113&id=45169 BRANCH master REVISION DETAIL https://p