D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoToolBoxLayout_p.h:310 > +private: > +int doLayout(const QRect &rect, bool notDryRun) const > { Also rename rect to size and QRect to QSize. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ogna

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you test my suggestions, it's looks good to me. INLINE COMMENTS > ognarb wrote in KoToolBoxDocker.cpp:39 > I found out that this QLabel is, it's the small draggable zone at the top of > the docker. Actual it's still a bit buggy in krita and karbon F6397172

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45113. ognarb added a comment. Revert a bit more REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45085&id=45113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356162 , @anthonyfieroni wrote: > Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 So I propose I add in a later diff the same confi

D16756: CalloutShape: Add a new shape to handle callouts

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY This is the start of a dedicated callout shape. It uses draw:type

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: anthonyfieroni, Callig

D16721: Use Krita toolbar in Karbon

ognarb marked 2 inline comments as done. ognarb added a comment. About the config for the KoKineticScroller. Do you perhaps know where to find the .kcfg file from calligra? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: a

D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoKineticScroller.cpp:28 > +{ > +KConfigGroup config = KSharedConfig::openConfig()->group(""); > +int sensitivity = config.readEntry("KineticScrollingSensitivity", 75); Let's have some name, KoKineticScroller or something. I also no