D16721: Use Krita toolbar in Karbon

ognarb marked 3 inline comments as done. ognarb added a comment. In D16721#355600 , @anthonyfieroni wrote: > Return QObjects, if you have problems copy linker output here. `make clean` solved the issue INLINE COMMENTS > anthonyfieroni w

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45085. ognarb added a comment. Removing useless arg REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45082&id=45085 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widg

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45082. ognarb marked 8 inline comments as done. ognarb added a comment. Remove bad code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45031&id=45082 BRANCH master REVISION DETAIL https://phabricator.kde.or

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Return QObjects, if you have problems copy linker output here. INLINE COMMENTS > KoToolBox.cpp:138 > button->setIconSize(QSize(iconSize, iconSize)); > -foreach (Section *section, d->sections) { > +foreach (Section *section, d->sections.values())

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#355367 , @anthonyfieroni wrote: > > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox > > I'm the maintainer of Karbon, for now.

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45031. ognarb marked 3 inline comments as done. ognarb added a comment. Fix some indentation problem REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45021&id=45031 BRANCH master REVISION DETAIL https://phabr

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45021. ognarb added a comment. Revert more change REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45020&id=45021 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widget

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45020. ognarb added a comment. Revert foreach and remove whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45018&id=45020 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED F

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45018. ognarb added a comment. Rever foreach REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45016&id=45018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES libs/widgets/CMa

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45016. ognarb marked an inline comment as done. ognarb added a comment. Revert some change more to come REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=44995&id=45016 BRANCH master REVISION DETAIL https://ph