D16388: Fix build with poppler 0.69

2018-10-23 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R8:56bd4bab320b: Fix build with poppler>=0.69 (authored by arojas). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16388?vs=44113&id=44137 REVISION DETAIL https://phab

D16388: Fix build with poppler 0.69

2018-10-23 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. i'm really wondering how broken SvgOutputDev.h is since we've changed the API a bit i think. If it's not using override i guess suddenly stopped overriding functions and noone realized... RE

D16388: Fix build with poppler 0.69

2018-10-23 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: aacid, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. arojas requested review of this revision. REVISION SUMMARY Remove no longer available Object::memCheck usage (which didn't do anythin

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-23 Thread Dag Andersen
danders added a comment. Yes, found it: https://bugs.kde.org/show_bug.cgi?id=289646 Afaics this affects only callout shapes where OO/LO breaks the intention of the odf spec by using the shape size and position as text area. This is ok (sort of) when text area and shape area overlap but n