D15775: Make the item background color and page cache properties available from View component

2018-09-26 Thread Camilla Boemann
boemann added a comment. Ahh well in that case I don't mind and the words code looks clean enough - I'll let someone else review the components REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0 Cc: boe

D15775: Make the item background color and page cache properties available from View component

2018-09-26 Thread Damien Caliste
dcaliste added a comment. Sorry, I was not clear in my description, I'm not setting the paper background color, but the item background color, i.e. the small area around and between the pages. In most desktop application it is light grey. But when using the KWCanvasItem in another context, i

D15775: Make the item background color and page cache properties available from View component

2018-09-26 Thread Camilla Boemann
boemann added a comment. 'm sorry but the background should not be settable - it's a document property at best and in fact paper is mostly white, so shouldn't even be settable REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, antho

D15775: Make the item background color and page cache properties available from View component

2018-09-26 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Currently, the item background color and