This revision was automatically updated to reflect the committed changes.
Closed by commit R8:ccb647780104: Try to avoid segfaults on shape factory not
found (authored by dcaliste).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D15728?vs=42242&id=42258#toc
REPOSITORY
R8 Calligra
CHANG
boemann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15728
To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
dcaliste created this revision.
dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.
REVISION SUMMARY
Try to catch every pattern of KoShapeReg
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5149f3864f5e: Add missing dependencies for PART_STAGE
(authored by dcaliste).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15679?vs=42088&id=42235
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:a06f24de8708: Move away from kdebug and kdelibs4 in
filter/sheets (authored by dcaliste).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15617?vs=41990&id=42234
REVIS
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Yes please, categorification and less dependency on the support library is
definitely a good thing :)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15617
To: dca
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
> Maybe it would be nice to replace the Q_ASSERT with an if (factory) {} and
put a warning in the else part in case of a wrong installation and plugins are
missing. What do you think ?