D15619: Remove use of kglobal.h in sheets

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15619 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15620 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15622: Upgrade intersect() to intersected() calls

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15622 To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15622: Upgrade intersect() to intersected() calls

2018-09-20 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some calls that I missed when upgrading

D15617: Move away from kdebug and kdelibs4 in filter/sheets

2018-09-20 Thread Damien Caliste
dcaliste updated this revision to Diff 41990. dcaliste added a comment. Update the patch, using categories for logging. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15617?vs=41981&id=41990 REVISION DETAIL https://phabricator.kde.org/D15617 AFFECTED FIL

D15617: Move away from kdebug and kdelibs4 in filter/sheets

2018-09-20 Thread Damien Caliste
dcaliste added a comment. @anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to update the diff as soon as ready. Thanks for the comment. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15617 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: a

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

2018-09-20 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some more deprecation changes. REPOSITORY R8 Calligra

D15619: Remove use of kglobal.h in sheets

2018-09-20 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Use QGlobalStatic instead of kdelibs4 kglobal. REPOSITO

D15617: Move away from kdebug and kdelibs4 in filter/sheets

2018-09-20 Thread Anthony Fieroni
anthonyfieroni added a comment. This is old practice, please make a logging category -> https://doc.qt.io/qt-5/qloggingcategory.html REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15617 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel

D15617: Move away from kdebug and kdelibs4 in filter/sheets

2018-09-20 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Like done by commit https://phabricator.kde.org/R8:50c3

D15236: Add missing dependencies in CMakeLists.txt

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:6b52b86ae29c: Add missing dependencies in CMakeLists.txt (authored by dcaliste). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15236?vs=40902&id=41970#toc REPOSITORY R8 Calligra CHANGES SINC

D15232: Update deprecated use of setResizeMode()

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:bc9397bc9959: Update deprecated use of setResizeMode() (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15232?vs=40895&id=41968 REVISION DETAIL

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:5873bc9d963c: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15231?vs=4

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:4ebf41d68d71: Replace deprecated use of QWeakPointer in favor of QPointer (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:e4a5dc4f46f2: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel()… (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1510

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

2018-09-20 Thread Damien Caliste
This revision was automatically updated to reflect the committed changes. Closed by commit R8:fe471acca71b: Don't use obsolete QRectF and QAbstractItemModel functions (authored by dcaliste). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14975?vs=40193&id=41961#toc REPOSITORY R8 Callig