D15412: [filters] Extend table lifetime

2018-09-12 Thread Anthony Fieroni
anthonyfieroni added a comment. Ping on this, did you try it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-09-12 Thread Anthony Fieroni
anthonyfieroni added a comment. Something as if (d->headerRows) { cursor->row = 0; } REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-09-12 Thread Anthony Fieroni
anthonyfieroni added a comment. It does not work, as you can see it overriding here https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutArea.cpp$571 so that's why i want to set it true before loop. REPOSITORY R8 Calligra REVISION DETAIL https://phabrica

D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-09-12 Thread Camilla Boemann
boemann added a comment. I am more thinking of this place: https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutTableArea.cpp$436 this shouldn't be set if we are doing a headerrow, so please try this: if (cursor->row >= d->headerRows) setV

D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-09-12 Thread Anthony Fieroni
anthonyfieroni added a comment. In D15428#324451 , @boemann wrote: > One reason why this might fail is if virginpage becomes false when we add the table headerrow (if we can fix this and that doesn't have other ill effect then I would prefer suc