boemann added a comment.
The idea is that if we are at the beginning of a new page we don't get in
here (virginpage is true)
so we only reset if we are somewhere down on a page meaning we wil have more
space to try on next time around
But we should reset if the only thing we fitted was th
anthonyfieroni added inline comments.
INLINE COMMENTS
> boemann wrote in KoTextLayoutTableArea.cpp:464
> nah this is too aggressive.
> There are definitely cases where setting to 0 is the correct thing to do.
> There might be some times we enter an infinite loop yes, but we need to catch
> this
boemann added inline comments.
INLINE COMMENTS
> KoTextLayoutNoteArea.cpp:143
> +
> +if (blockLayoutLine.isValid()) {
> +d->labelYOffset += blockLayoutLine.ascent();
I'm fine with this change
> KoTextLayoutTableArea.cpp:464
> +//if we couldn't fit the header rows
> +
anthonyfieroni updated this revision to Diff 41418.
anthonyfieroni added a comment.
Initialize labelYOffset even layout line is not valid
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15428?vs=41409&id=41418
REVISION DETAIL
https://phabricator.kde.org/D1
anthonyfieroni edited the summary of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15428
To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
anthonyfieroni retitled this revision from "[textlayout] Don't enter infinite
loop when table are misfit" to "[textlayout] Don't enter infinite loop when
table is misfit".
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15428
To: anthonyfieroni, #calligra:_3.0, danders,
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Calligra: 3.0, danders, boemann.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
anthonyfieroni requested review of this revision.
REVISION SUMMARY
Also QTextLine can crash due to its val
