D15103: Replace deprecated use of QWeakPointer in favor of QPointer

2018-08-31 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In that case, things build and run fine for me, and while i can't comment on performance here, i understand that making QPointer sufficiently performant was basically why QWeakPointer was d

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-31 Thread Camilla Boemann
boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working INLINE COMMENTS > TestBlockLayout.cpp:333 > //qDebug() << blockLay

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-31 Thread Dag Andersen
danders added a comment. Ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14901 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, cochise, vandenoever